Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retry in case of an nginx timeout error #35

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Do not retry in case of an nginx timeout error #35

merged 1 commit into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. Do not retry in case of an nginx timeout error 

    When the client request timeouts, the nginx returns an HTML error page.

We should not retry when that happens (which would fail the respone.json() call
as it is not a json).

This PR pulls the parsing of the response body out of the retry logic.
    @mdumandag
    mdumandag committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0b5d8c3 View commit details
    Browse the repository at this point in the history