Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON.parse/stringify to clone an object #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p3k
Copy link

@p3k p3k commented Aug 21, 2024

We noticed that the clone() function can cause an error if the constructor property is not a function.

This is a (rare?) case when a POJO has a property named constructor:

{
   "building": "House A",
   "constructor": "Construction Company Ltd."
}

This PR replaces the main part of the clone() function with the JSON.parse/stringify combo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant