-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for a new release [4.4.2] #172
Conversation
WalkthroughIn version 4.4.2, the Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- lib/uploadcare/ruby/version.rb (1 hunks)
Files skipped from review due to trivial changes (1)
- lib/uploadcare/ruby/version.rb
Additional Context Used
LanguageTool (8)
CHANGELOG.md (8)
Near line 5: Possible typo: you repeated a word
Context: ...# Changelog ## 4.4.2 — 2024-05-29 ### Fixed * Fixed theUploadcare::File.remote_copy
meth...
Rule ID: ENGLISH_WORD_REPEAT_RULE
Near line 6: Possible missing comma found.
Context: ...ixed theUploadcare::File.remote_copy
method which raised an `ApiStruct::EntityError...
Rule ID: AI_HYDRA_LEO_MISSING_COMMA
Near line 13: Possible typo: you repeated a word
Context: ...Converter. ## 4.4.1 — 2024-04-27 ### Added * Added
AWS Rekognition Moderation` Add-On. * ...
Rule ID: ENGLISH_WORD_REPEAT_RULE
Near line 124: In American English, abbreviations like “etc.” require a period.
Context: ...s mime-type, image (dimensions, format, etc), video information (duration, format, ...
Rule ID: ETC_PERIOD
Near line 124: In American English, abbreviations like “etc.” require a period.
Context: ...information (duration, format, bitrate, etc), audio information, etc - Field `met...
Rule ID: ETC_PERIOD
Near line 124: In American English, abbreviations like “etc.” require a period.
Context: ...rmat, bitrate, etc), audio information, etc - Fieldmetadata
that includes arbi...
Rule ID: ETC_PERIOD
Near line 130: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ...plications ### Added - Add Uploadcare API interface: -Uploadcare::FileMetadata
-...
Rule ID: ACRONYM_TAUTOLOGY
Near line 156: Possible typo: you repeated a word
Context: ...tureVerifier## 3.1.1 — 2021-10-13 - Fixed
Uploadcare::File#store- Fixed
Uploadcare::File#delete` ## 3.1.0 — 2...
Rule ID: ENGLISH_WORD_REPEAT_RULE
Markdownlint (70)
CHANGELOG.md (70)
83: Expected: asterisk; Actual: dash
Unordered list style
84: Expected: asterisk; Actual: dash
Unordered list style
92: Expected: asterisk; Actual: dash
Unordered list style
93: Expected: asterisk; Actual: dash
Unordered list style
97: Expected: asterisk; Actual: dash
Unordered list style
110: Expected: asterisk; Actual: dash
Unordered list style
111: Expected: asterisk; Actual: dash
Unordered list style
112: Expected: asterisk; Actual: dash
Unordered list style
113: Expected: asterisk; Actual: dash
Unordered list style
114: Expected: asterisk; Actual: dash
Unordered list style
115: Expected: asterisk; Actual: dash
Unordered list style
116: Expected: asterisk; Actual: dash
Unordered list style
117: Expected: asterisk; Actual: dash
Unordered list style
118: Expected: asterisk; Actual: dash
Unordered list style
119: Expected: asterisk; Actual: dash
Unordered list style
123: Expected: asterisk; Actual: dash
Unordered list style
124: Expected: asterisk; Actual: dash
Unordered list style
125: Expected: asterisk; Actual: dash
Unordered list style
126: Expected: asterisk; Actual: dash
Unordered list style
130: Expected: asterisk; Actual: dash
Unordered list style
131: Expected: asterisk; Actual: dash
Unordered list style
132: Expected: asterisk; Actual: dash
Unordered list style
133: Expected: asterisk; Actual: dash
Unordered list style
134: Expected: asterisk; Actual: dash
Unordered list style
138: Expected: asterisk; Actual: dash
Unordered list style
142: Expected: asterisk; Actual: dash
Unordered list style
143: Expected: asterisk; Actual: dash
Unordered list style
147: Expected: asterisk; Actual: dash
Unordered list style
151: Expected: asterisk; Actual: dash
Unordered list style
152: Expected: asterisk; Actual: dash
Unordered list style
156: Expected: asterisk; Actual: dash
Unordered list style
157: Expected: asterisk; Actual: dash
Unordered list style
161: Expected: asterisk; Actual: dash
Unordered list style
162: Expected: asterisk; Actual: dash
Unordered list style
163: Expected: asterisk; Actual: dash
Unordered list style
167: Expected: asterisk; Actual: dash
Unordered list style
168: Expected: asterisk; Actual: dash
Unordered list style
172: Expected: asterisk; Actual: dash
Unordered list style
173: Expected: asterisk; Actual: dash
Unordered list style
174: Expected: asterisk; Actual: dash
Unordered list style
178: Expected: asterisk; Actual: dash
Unordered list style
182: Expected: asterisk; Actual: dash
Unordered list style
183: Expected: asterisk; Actual: dash
Unordered list style
187: Expected: asterisk; Actual: dash
Unordered list style
188: Expected: asterisk; Actual: dash
Unordered list style
189: Expected: asterisk; Actual: dash
Unordered list style
190: Expected: asterisk; Actual: dash
Unordered list style
191: Expected: asterisk; Actual: dash
Unordered list style
197: Expected: asterisk; Actual: dash
Unordered list style
201: Expected: asterisk; Actual: dash
Unordered list style
202: Expected: asterisk; Actual: dash
Unordered list style
203: Expected: asterisk; Actual: dash
Unordered list style
204: Expected: asterisk; Actual: dash
Unordered list style
205: Expected: asterisk; Actual: dash
Unordered list style
131: Expected: 2; Actual: 4
Unordered list indentation
132: Expected: 2; Actual: 4
Unordered list indentation
42: Expected: 1; Actual: 2
Multiple consecutive blank lines
55: Expected: 1; Actual: 2
Multiple consecutive blank lines
62: Expected: 1; Actual: 2
Multiple consecutive blank lines
5: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
8: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
13: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
39: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
6: null
Lists should be surrounded by blank lines
9: null
Lists should be surrounded by blank lines
14: null
Lists should be surrounded by blank lines
18: null
Lists should be surrounded by blank lines
40: null
Lists should be surrounded by blank lines
102: null
Lists should be surrounded by blank lines
Additional comments not posted (2)
CHANGELOG.md (2)
3-7
: The changelog entry for the fix inUploadcare::File.remote_copy
is clear and accurately reflects the changes made in the PR.
7-10
: The changelog entry for the addition of theDocument Info
API inDocumentConverter
is well-documented and aligns with the PR's objectives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out why checks fail.
They seem to be from a cached dependency issue, new push, rebuilds fixed it. |
Description
Fixed
Uploadcare::File.remote_copy
method which raised anApiStruct::EntityError: {url} must be Hash
. Now returns a string instead of aFile
entity instance.Added
Document Info
API added inDocumentConverter
.Checklist
Summary by CodeRabbit
New Features
Document Info
API to the DocumentConverter.Bug Fixes
Uploadcare::File.remote_copy
method to return a string instead of aFile
entity instance.Chores