Sign URL uploads if configured #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeosh
force-pushed
the
fix-signing-url-uploads
branch
from
e0f08dd
to
2449902
Compare
Fix namespace for service Add spec for upload_from_url Fix requiring of SignatureGenerator and location of tests
geeosh
force-pushed
the
fix-signing-url-uploads
branch
from
9676ddd
to
ccc0c84
Compare
|
@geeosh The PR looks good to me! |
|
@kraft001 sure thing, I can submit an update for this later this week. |
vipulnsward
added a commit
that referenced
this pull request
Mar 9, 2024
* When polling, raise if an error is returned (#142) Previously, if an error from the API was returned while polling for updates on a file, it would continue polling. I updated it so that it raises a RequestError if the API returns an error status. If not, it raises a RetryError, which is swallowed by the retry gem's `with_retries` block. Example of an error that led to continued polling: ``` {"status":"error","error":"File validation error: Uploading of these file types is not allowed.","error_code":"DownloadFileValidationFailedError"} ``` * Sign URL uploads if configured (#139) Fix namespace for service Add spec for upload_from_url Fix requiring of SignatureGenerator and location of tests * Merge with main and add changelog * Bump version to 4.4.0 * Apply suggestions from code review Co-authored-by: Roman Sedykh <[email protected]> --------- Co-authored-by: Josh Schwartzman <[email protected]> Co-authored-by: Roman Sedykh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having Signed Uploads enabled, and using
Uploadcare::Uploader.upload, it doesn't send thesignatureandexpireparameters if using a URL (whereas it does if you use a file).This PR introduces a few changes to use
(Param::Upload::SignatureGeneratorto add thesignatureandexpireto theupload_from_url_bodymethod.Ideally both the
upload_from_url_bodymethod and theupload_many_bodymethod would use theParam::Upload::UploadParamsGeneratorservice to generate params. Since the param keys are different, I didn't take the time to refactor that service, but it wouldn't be too hard. There is already code repetition for thestore_valuein both places.