Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize serializer exports #84

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Dec 1, 2024

The current serializer exports is strange:

  • Exports it as defaultSerializers, but none of those are applied by default, unlike bunyan or pino.
  • Has error and datadogSerializer which is inconsistent.. one has Serializer prefix and another doesn't.

This PR addresses these inconsistencies. Contains breaking changes.

@satazor satazor force-pushed the feature/support-glob-alike branch 4 times, most recently from 1d4f404 to 4a1d98d Compare December 1, 2024 21:58
@satazor satazor force-pushed the enhancement/standardize-serializers-exports branch from 46ccd61 to 41b400d Compare December 1, 2024 21:59
@satazor satazor force-pushed the feature/support-glob-alike branch 4 times, most recently from 0faa1f9 to db89d46 Compare December 2, 2024 12:00
boliveira
boliveira previously approved these changes Dec 2, 2024
@satazor satazor force-pushed the feature/support-glob-alike branch from db89d46 to 6fc8e71 Compare December 3, 2024 02:39
@satazor satazor force-pushed the enhancement/standardize-serializers-exports branch 2 times, most recently from 24e8700 to f1dbff8 Compare December 3, 2024 02:41
@satazor satazor force-pushed the feature/support-glob-alike branch from 6fc8e71 to 16d3191 Compare December 4, 2024 17:37
Base automatically changed from feature/support-glob-alike to master December 4, 2024 18:16
@boliveira boliveira dismissed their stale review December 4, 2024 18:16

The base branch was changed.

@satazor satazor force-pushed the enhancement/standardize-serializers-exports branch from f1dbff8 to 430edb7 Compare December 4, 2024 18:17
@boliveira boliveira merged commit e4de1dd into master Dec 4, 2024
2 checks passed
@boliveira boliveira deleted the enhancement/standardize-serializers-exports branch December 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants