Skip to content

Commit

Permalink
Merge branch 'fix/41-correct-solr-ports-v2' into 'development'
Browse files Browse the repository at this point in the history
Fix/41 correct solr ports v2 in Development

See merge request sdbm/sdbmss!42
  • Loading branch information
emeryr-upenn committed Sep 9, 2022
2 parents cca5ac7 + cd1d567 commit d826c02
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 6 deletions.
5 changes: 5 additions & 0 deletions README-development.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ Generate separate keys (for each) by running rails task secret.

URL for SOLR server, using relative location of docker service (using name 'solr' from docker-compose.yml)

NB: The SOLR port here and everywhere else in the code is `8983`. Previous versions
of the code had `8982` in some cases. This was wrong and created a conflict
between Jetty (which was set to `8983` and the docker-compose values, which
had `8982`).

SOLR_URL=http://solr:8983/solr/development

**3. Build and Run (First Time)**
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ DEPRECATED -- USING ANSIBLE

URL for SOLR server, using relative location of docker service (using name 'solr' from docker-compose.yml)

NB: The SOLR port here and everywhere else in the code is `8983`. Previous versions
of the code had `8982` in some cases. This was wrong and created a conflict
between Jetty (which was set to `8983` and the docker-compose values, which
had `8982`).

SOLR_URL=http://solr:8983/solr/development

**3. (Optional) Create a file VERSION in the root folder of the cloned repository.**
Expand Down
2 changes: 1 addition & 1 deletion config/SolrMarc/config.properties
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ solr.indexer.properties = index.properties
# NOTE:
# When using the solr:marc:index rake task, this value will be automatically
# looked up from your solr.yml, and the value here will NOT be used.
solr.hosturl = http://localhost:8982/solr/update
solr.hosturl = http://localhost:8983/solr/update

# MARC handling parameters
marc.to_utf_8 = true
Expand Down
2 changes: 1 addition & 1 deletion config/sunspot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
production:
solr:
# hostname: localhost
port: 8982
port: 8983
log_level: WARNING
# path: /solr/production
# read_timeout: 2
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ services:
context: .
dockerfile: Dockerfile
ports:
- "8982:8982"
- "8983:8983"
# logging:
# driver: "journald"
links:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ services:
image: 'gitlab.library.upenn.edu/sdbm/sdbmss/sdbmss_web:${SDBMSS_IMAGE_TAG}'
restart: always
ports:
- "8982:8982"
- "8983:8983"
# env_file: .docker-environment
# logging:
# driver: "journald"
Expand Down
2 changes: 1 addition & 1 deletion lib/sdbmss/util.rb
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ def int? s
# really can take 5 secs, if not more.
def wait_for_solr_to_be_current
host = ENV['SOLR_URL'].present? ? URI(ENV['SOLR_URL']).host : 'localhost'
uri = "http://#{host}:8982/solr/admin/cores?action=STATUS&core=test"
uri = "http://#{host}:8983/solr/admin/cores?action=STATUS&core=test"

current = false
count = 0
Expand Down
2 changes: 1 addition & 1 deletion run_tests.sh
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Do NOT use this when running in a Docker container!

export RAILS_ENV=test
export SOLR_URL="http://127.0.0.1:8982/solr/test"
export SOLR_URL="http://127.0.0.1:8983/solr/test"

bundle exec god -c sdbmss_test.god -l log/god_test.log

Expand Down

0 comments on commit d826c02

Please sign in to comment.