20200717 mk form submission spec #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e rendering). Altered Illiad service to use instance methods rather than class methods to enable stubbing.
cgalarza
reviewed
Jul 17, 2020
cgalarza
approved these changes
Jul 17, 2020
…class method interface
# Conflicts: # app/controllers/concerns/post_processor.rb # app/services/illiad.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec that validates (as much as reasonably possible) the submission behaviour of the ILL request form. Check that Email is queued for sending and confirmation page is displayed after submission.