Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup at penn #39

Open
wants to merge 77 commits into
base: 35-colenda-bento-preview
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
9997c73
schema refactor changes; change field type for full_text_link field
magibney Oct 21, 2019
2910e8d
add hooks for indexing other institutions records; and actual indexer…
magibney Dec 6, 2019
9966077
was using wrong oclc function for duke cluster_id
magibney Dec 10, 2019
8757c01
added brown indexer, patterned after duke
magibney Dec 10, 2019
114d4cf
add top-level indexing script for brown
magibney Dec 10, 2019
653f6bb
add stanford indexer and top-level script
magibney Dec 10, 2019
717852e
add cornell indexer and top-level script
magibney Dec 10, 2019
9238412
add columbia indexer and top-level script
magibney Dec 10, 2019
f9c28f8
initial facet UI adaptation for 7 record sources
magibney Dec 10, 2019
972081d
TEMPORARY: query faceting (not field) for multi-source format_f
magibney Dec 11, 2019
e9ed6e9
add princeton indexer, facets, and top-level script
magibney Dec 11, 2019
1478c0d
properly namespace Stanford's ids
magibney Dec 11, 2019
90dc3f4
add better label for link to source context
magibney Dec 11, 2019
fb26988
dynamic record source preferences, etc.
magibney Dec 12, 2019
36e3631
change join filter queries to match solr warming
magibney Dec 17, 2019
e2336db
add tiered dedupe respecting asserted encoding level
magibney Dec 18, 2019
cb777b0
temporary(?) disable/reorder some facets for public demo
magibney Dec 19, 2019
ab64f6f
change catalog landing page Franklin text for POD explanation
magibney Dec 20, 2019
b433349
add Harvard
magibney Dec 20, 2019
2779d91
Add Ivies+ Request button to items without an alma_mms_id
Feb 19, 2020
4ed48d2
add Chicago
magibney Feb 12, 2020
f471622
prevent bloated requests by more carefully deduping dedupe params
magibney Feb 12, 2020
96e832c
modified facet options for local deployment
magibney Feb 19, 2020
7cf6ed0
Updated BD+ to Ivies+ Request for demo
Feb 19, 2020
706aac9
adjustments to facets and link display, per egmowens
magibney Feb 24, 2020
a11e1f3
Added methods to interact with BD API
Mar 6, 2020
f6604fb
Added controller, views, and routes for BD requesting
Mar 6, 2020
86de85b
Set URL for Ivies+ requesting
Mar 6, 2020
b977b9d
Added link to Ivies+ Requests page and changed button handling for un…
Mar 6, 2020
71c9a88
Added additional env vars to nginx conf
Mar 6, 2020
606606a
Temp fix for broken auth
Mar 9, 2020
ac25dd2
Replaced references to Ivies+ with BorrowDirect+
Mar 9, 2020
219653d
Bibs with a single holding and item descriptions automatically shows …
Oct 11, 2019
9f53436
Fixed HTML
Oct 11, 2019
a218fb1
Fix to account for asset precompilation
Oct 11, 2019
ab2d681
Revert "Merge pull request #18 from upenn-libraries/single_holding_fix"
Oct 30, 2019
4c74f7e
edit FEATURED loc to add Moelis Lounge
schultz-upenn Oct 30, 2019
2a527df
Fixed data offset issue that was hiding 'Request' link for the 101st …
Nov 11, 2019
3e5129a
update collection news blog feed, per vallhonr
magibney Dec 5, 2019
58997f7
fix "More collection news" link; point to new blog
magibney Dec 9, 2019
a6ddd9e
bookplates link to pantheon, not nebraska (per vallhonr)
magibney Dec 23, 2019
3833f1b
Added test_access flag to correct eresource linking
Jan 24, 2020
e45ab4c
create new loc Featured Books Display in MPA library
schultz-upenn Jan 7, 2020
18edd98
update database a-z list url
tampakis Jun 11, 2020
d956f4c
add last-10-years publication date facet bucket
magibney Jan 31, 2020
d17bda3
filter out non-whitelisted "source specified" subject vocabs
magibney Jan 31, 2020
bea2f9a
move "Penn Library Web" access facet to "Online library" location facet
magibney Jan 31, 2020
cba9194
Revert "add last-10-years publication date facet bucket"
magibney Feb 24, 2020
4ac8abb
also whitelist subject display terms where source thesaurus specified
magibney Feb 24, 2020
2923087
prevent duplicate subjects from being displayed
magibney Feb 24, 2020
b71b0fd
add top-level catch-all "Veterinary" library alias
magibney Feb 24, 2020
262eef8
Removed linking to physical item services
Mar 16, 2020
d450b67
removed call to deprecated franklin_alerts, per ivangold
magibney Mar 24, 2020
55d7890
hotfix: only proxy "View and filter" link when user has proxy-equival…
magibney Mar 24, 2020
d45f0a9
temporarily add links to hathi records corresponding to local holdings
tampakis Jun 11, 2020
75bf95b
remove VIVO from "Other resources", per baowei
magibney Apr 13, 2020
2bb3181
clarify patron classes authorized for Hathi COVID-19 special access
magibney Apr 21, 2020
3263afb
link to details regarding Hathi ETAS access authorization
tampakis Jun 11, 2020
69aab77
Adds initial colenda bento integration
tampakis May 20, 2020
60921b6
Add colenda tab
ivavictoria May 26, 2020
482bfcf
Remove homepage feedback icon
ivavictoria May 26, 2020
a0350e8
Delete feedback image
ivavictoria May 26, 2020
1a610fd
Colenda engine: fix results with only 1 item
ivavictoria May 27, 2020
35ec253
Add publisher & thumbnail to colenda bento results
ivavictoria May 28, 2020
0fad92d
fix colenda view results link
ivavictoria May 28, 2020
879714b
Attempt to reinstate 'expert help' functionality
tampakis Jun 11, 2020
1ad5439
pulls in colenda thumbnail url when present, expert results formatting
tampakis Jun 9, 2020
d16cec9
update homepage text
tampakis Jun 11, 2020
cad65fc
restore lambdas for subject specialists post-rebase
magibney Jun 11, 2020
6ea7fe9
Revert "Removed linking to physical item services"
magibney Jun 15, 2020
87e4bea
intermediate: re-enable some services for physical items (Books By Ma…
magibney Jun 18, 2020
7176a83
define etas_monograph method
magibney Jun 26, 2020
b21cdb3
first pass at hacky DOM-contextual display of Pickup@Penn link
magibney Jun 29, 2020
ceaf1dd
fix typo
magibney Jun 29, 2020
8b0f5e1
change object literal notation?
magibney Jun 29, 2020
5842543
fix bad else if block
magibney Jun 29, 2020
8e943ee
debugging differentiation
magibney Jun 29, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
also whitelist subject display terms where source thesaurus specified
  • Loading branch information
magibney authored and tampakis committed Jun 11, 2020
commit 4ac8abb7af508876fb3c3241295ec2f4de3cc109
4 changes: 3 additions & 1 deletion lib/penn_lib/marc.rb
Original file line number Diff line number Diff line change
@@ -506,7 +506,9 @@ def get_subjects_from_600s_and_800(rec, indicator2)
acc += rec.fields
.select { |f| subject_600s.member?(f.tag) ||
(f.tag == '880' && has_subfield6_value(f, /^(#{subject_600s.join('|')})/)) }
.select { |f| f.indicator2 == indicator2 || (f.indicator2 == '7' && indicator2 == '0') }
.select { |f| f.indicator2 == indicator2 || (f.indicator2 == '7' && indicator2 == '0' && f.any? do |sf|
sf.code == '2' && %w(aat cct fast jlabsh lcsh lcstt lctgm local/osu mesh ndlsh nlksh).member?(sf.value)
end)}
.map do |field|
#added 2017/04/10: filter out 0 (authority record numbers) added by Alma
value_for_link = join_subfields(field, &subfield_not_in(%w{0 6 8 2 e w}))