Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS #121

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/controllers/franklin_alma_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ def request_options
api = api_instance.ezwadl_api[0]
options = { user_id: userid, consider_dlr: true }
response_data = api_instance.request(api.almaws_v1_bibs.mms_id_request_options, :get, params.merge(options))
pickup_at_penn = false
results = response_data['request_option'].map do |option|
request_url = option['request_url']
details = option['general_electronic_service_details'] || option['rs_broker_details'] || {}
Expand All @@ -472,6 +473,7 @@ def request_options
when 'HOLD'
# TODO: when libraries reopen: remove conditional, Pickup@Penn=>Request
unless suppress_pickup_at_penn(ctx)
pickup_at_penn = true
{
option_name: 'Pickup@Penn',
# option_url: option['request_url'],
Expand Down Expand Up @@ -540,7 +542,7 @@ def request_options
if ['Associate', 'Athenaeum Staff', 'Faculty', 'Faculty Express',
'Faculty Spouse', 'Grad Student', 'Library Staff', 'Medical Center Staff',
'Retired Library Staff', 'Staff', 'Undergraduate Student']
.member?(session['user_group']) && !suppress_pickup_at_penn(ctx)
.member?(session['user_group']) && pickup_at_penn
results.append(
{
option_name: 'Books By Mail',
Expand Down