Run the jlumbroso/free-disk-space action in CI jobs #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment-trigger workflow Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit c0bd150)
…ish-artifacts job Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit bb6713d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Experiments logged in crossplane-contrib/provider-upjet-aws#1180 reveal that the
jlumbroso/free-disk-spaceaction helps with the failinge2e(uptest) CI workflows &publish-artifactsCI jobs. Theuptestruns have failed on the standard (ubuntu-22.04) runners. I've performed experiments with two example manifests on standard runners:uptestfor theFirewall.networkfirewallexample manifest was run here, with 4 providers installed: The AWS provider family config package and 3 resource providers:provider-aws-{networkfirewall, ec2, s3}, withec2being the largest (in terms of CRDs installed) AWS resource provider. Thisuptestrun has failed consistently due to insufficient disk space while installing thes3resource provider. The other 3 provider packages were successfully installed:uptestruns for theCluster.eksexample manifest also failed consistently with a disk space error here:With the
jlumbroso/free-disk-spaceaction run as part of thee2eCI workflow, things have consistently improved. Here are examples from successful runs:Firewall.networkfirewall-> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085639241/job/22093639643Cluster.eks-> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085642042/job/22093648022This PR introduces the
jlumbroso/free-disk-spaceaction to clean up some disk space on the workflow runner beforeuptestis run and beforemake build.allis invoked (during thepublish-artifactsjob.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Following jobs on standard runners (on top of the
standard-runnersbranch):Firewall.networkfirewall-> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085639241/job/22093639643Cluster.eks-> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085642042/job/22093648022