Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable options for Update and Import steps #170

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

sergenyalcin
Copy link
Member

This PR adds disable options for Update and Import steps and adds defer statment to remove all test directory before completing the cases.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Locally tested

Add defer statment to remove all test directory before completing the cases

Signed-off-by: Sergen Yalçın <[email protected]>
@mbbush
Copy link
Contributor

mbbush commented Dec 31, 2023

@sergenyalcin This looks really useful, but I wasn't able to get it to do what I was trying to do when running locally.

In an example containing multiple resources, I added the uptest.upbound.io/disable-import: "true" annotation to one of them (an Object.s3.aws) which I know will fail the import step, hoping to be able to test import for the rest of the resources. But it seemed to have no effect.

Is this not how this works? Do you think you could make it work this way?

@sergenyalcin sergenyalcin merged commit 000c280 into upbound:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants