Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "branch_name", "version" and "regorg" parameters to the "Provider Publish Service Artifacts" reusable workflow #156

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Oct 12, 2023

Description of your changes

This PR parameterizes the image registry and repo, the branch name and the version used for building and publishing the provider packages so that we can still use the reusable workflow Provider Publish Service Artifacts for publishing packages to repositories other than xpkg.upbound.io/upbound and with customizable version strings.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested manually under a different Github org.

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar force-pushed the parameterize-regorg branch 2 times, most recently from f23acdf to 35b706c Compare October 12, 2023 19:35
"Provider Publish Service Artifacts" reusable workflow

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar force-pushed the parameterize-regorg branch from 35b706c to 8f1bf4f Compare October 12, 2023 20:01
@ulucinar ulucinar merged commit 96026e7 into upbound:main Oct 12, 2023
5 checks passed
@ulucinar ulucinar deleted the parameterize-regorg branch October 12, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants