Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource import test's new and old ID assertion #151

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Oct 9, 2023

Description of your changes

In https://github.com/upbound/provider-aws/actions/runs/6460833777/job/17539319778, we have encountered the following error in the resource import tests:

...
logger.go:42: 19:43:15 | case/2-import | running command: [sh -c new_id=$(${KUBECTL} get streamconsumer.kinesis.aws.upbound.io/example -o=jsonpath='{.status.atProvider.id}') && old_id=$(${KUBECTL} get streamconsumer.kinesis.aws.upbound.io/example -o=jsonpath='{.metadata.annotations.uptest-old-id}') && [ "$new_id" == "$old_id" ]]
logger.go:42: 19:43:15 | case/2-import | sh: 1: [: arn:aws:kinesis:us-west-1:153891904029:stream/example/consumer/example-consumer:1696879709: unexpected operator
logger.go:42: 19:43:15 | case/2-import | command failure, skipping 2 additional commands
...

We need to use the = operator instead of the == operator with sh.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested manually with sh.

- We need to use the operator `=` instead of `==` with sh

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit b908f6a into upbound:main Oct 10, 2023
5 checks passed
@ulucinar ulucinar deleted the fix-import-assert branch October 10, 2023 07:11
@github-actions
Copy link

Successfully created backport PR #152 for release-0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants