Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quotes causing updoc crash #138

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix quotes causing updoc crash #138

merged 1 commit into from
Sep 29, 2023

Conversation

turkenf
Copy link
Contributor

@turkenf turkenf commented Sep 29, 2023 •
edited
Loading

Description of your changes

This PR fixes quotes in provider-updoc workflow.
Related job: https://github.com/upbound/provider-gcp/actions/runs/6348941231/job/17246371408

I have:

  • Run make reviewable test to ensure this PR is ready for review.

ulucinar
ulucinar approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

@turkenf turkenf merged commit 06f24d4 into upbound:main Sep 29, 2023
5 checks passed
@turkenf turkenf deleted the updoc-quote branch September 29, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar ulucinar approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turkenf @ulucinar