Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default branch in CI and fix pushing to marketplace #136

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Sep 12, 2024

Description of your changes

Follow up on #132

Looks like, we cannot login to multiple orgs in Upbound marketplace with their tokens and push them. It looks like the latter login overrides the previous ones.

image

I have:

Need help with this checklist? See the cheat sheet.

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah use this way than

@turkenh turkenh marked this pull request as ready for review September 13, 2024 14:16
@turkenh
Copy link
Member Author

turkenh commented Sep 13, 2024

It looks like docker login simply ignores whatever I put after the registry url, so it is not possible to login using two different tokens for different accounts at the same time:

❯ docker login -u $(jq -r '.Username' ~/.up/space.token.json) -p $(jq -r '.Secret' ~/.up/space.token.json) xpkg.upbound.io/some-arbitrary-repositry123
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Login Succeeded
I logged in xpkg.upbound.io/some-arbitrary-repositry123 above, and I am only seeing this added to my ~/.docker/config.json
❯ cat ~/.docker/config.json
{
	"auths": {
		"xpkg.upbound.io": {}
	},
	"credsStore": "osxkeychain"
}

Related: moby/moby#37569 (comment)

@turkenh turkenh merged commit fc21680 into upbound:main Sep 13, 2024
11 of 15 checks passed
Copy link

Backport failed for release-1.15, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.15
git worktree add -d .worktree/backport-136-to-release-1.15 origin/release-1.15
cd .worktree/backport-136-to-release-1.15
git switch --create backport-136-to-release-1.15
git cherry-pick -x 3f5f7064e145ce381fe1807d032fe051e95ae9ab

Copy link

Backport failed for release-1.16, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.16
git worktree add -d .worktree/backport-136-to-release-1.16 origin/release-1.16
cd .worktree/backport-136-to-release-1.16
git switch --create backport-136-to-release-1.16
git cherry-pick -x 3f5f7064e145ce381fe1807d032fe051e95ae9ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants