Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Project Cards Not Responsive #52

Merged

Conversation

aya-en-amir
Copy link
Contributor

@aya-en-amir aya-en-amir commented Nov 17, 2024

https://linear.app/uoft-blueprint-internal/issue/INTL-34/bug-project-cards-not-responsive
Projects Cards used to squish in mobile view, now they stack vertically.

@aya-en-amir aya-en-amir changed the title Fixed Project Cards responsiveness to vertically align in mobile view. Bug - Project Cards Not Responsive Nov 17, 2024
Copy link
Contributor

@alexlewis9 alexlewis9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stacking and alignment looks good. The text on the buttons and the buttons themselves are a bit small in the mobile view. Not sure if this should be addressed separately.

@alexlewis9 alexlewis9 force-pushed the enayaamir/intl-34-bug-project-cards-not-responsive branch from 5d678b2 to 2aeb772 Compare November 18, 2024 20:56
@jordanjanakievski
Copy link
Collaborator

The stacking and alignment looks good. The text on the buttons and the buttons themselves are a bit small in the mobile view. Not sure if this should be addressed separately.

Yeah I agree the buttons get a little squished. We can address that with this PR. Should just be making sure the padding is still proportional when in the smaller view

@jordanjanakievski jordanjanakievski merged commit 500c027 into main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants