Mongoose user types #12
Conversation
| @@ -36,6 +64,11 @@ UserSchema.methods.isValidPassword = async function ( | |||
| return compare; | |||
| }; | |||
|
|
|||
| const User = mongoose.model<User, UserModel>("user", UserSchema); | |||
There was a problem hiding this comment.
i would just move it down after the discriminators, up to you
| // schema for reviewer | ||
| }, options)); | ||
|
|
||
| const RecommenderSchema = User.discriminator('Recommender', |
There was a problem hiding this comment.
theres no role called recommender, its only counselor lol so you can remove this
There was a problem hiding this comment.
bro idk all the mans keep shouting out random user types i was confused 😂
| @@ -18,7 +19,34 @@ const UserSchema = new Schema<User, UserModel>({ | |||
| type: String, | |||
There was a problem hiding this comment.
this should just be multiple booleans like user.student=true or false like you had earlier
There was a problem hiding this comment.
don't think we need booleans can just use instanceof
There was a problem hiding this comment.
| @@ -3,6 +3,7 @@ import bcrypt from "bcrypt"; | |||
| import { User } from "../types"; | |||
|
|
|||
| const Schema = mongoose.Schema; | |||
| const options = { discriminatorKey: 'userType' }; | |||
There was a problem hiding this comment.
would just change to type since userType is just repeating info
| @@ -36,6 +64,11 @@ UserSchema.methods.isValidPassword = async function ( | |||
| return compare; | |||
| }; | |||
|
|
|||
| const User = mongoose.model<User, UserModel>("user", UserSchema); | |||
There was a problem hiding this comment.
i would just move it down after the discriminators, up to you
Rishab help! -alex & stella
are we discriminating properly