Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - 1.5: Firebase Auth: Email/Password #60

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

lxyhan
Copy link
Contributor

@lxyhan lxyhan commented Nov 16, 2024

Bug Fix: Resolved an issue in Google Authentication with TypeScript integration.
Sign-In/Sign-Up Form: Built a dynamic form supporting both email/password and Google sign-ins, with a toggle for sign-up.
Error Handling: Implemented detailed error messages for form validation and Firebase errors (e.g., invalid credentials, weak passwords, etc.).
Firebase Email Auth: Fully set up Firebase Email Authentication for user registration and login.

@stephanieyflu
Copy link
Contributor

I'm wondering if it would be useful to ensure that the inputs are valid before clicking Sign Up with Email. For example, an error message could be displayed while the user types in their email if it doesn't match a valid format, or password strength hints could be displayed dynamically instead of when you submit the form.

@lxyhan
Copy link
Contributor Author

lxyhan commented Nov 18, 2024

I'm wondering if it would be useful to ensure that the inputs are valid before clicking Sign Up with Email. For example, an error message could be displayed while the user types in their email if it doesn't match a valid format, or password strength hints could be displayed dynamically instead of when you submit the form.

Hi Stephanie! Thanks for the suggestion, and I agree that input checking would be useful. I'll make another commit as soon as possible and I hope you can review the PR after I'm done. Thanks again!

@Ron-Madan Ron-Madan linked an issue Nov 18, 2024 that may be closed by this pull request
@Ron-Madan Ron-Madan linked an issue Nov 18, 2024 that may be closed by this pull request
stephanieyflu
stephanieyflu previously approved these changes Nov 20, 2024
Copy link
Contributor

@stephanieyflu stephanieyflu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like there's a conflict though

Ron-Madan
Ron-Madan previously approved these changes Nov 21, 2024
Copy link
Contributor

@Ron-Madan Ron-Madan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Ron-Madan Ron-Madan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lxyhan lxyhan merged commit abcc2b3 into main Nov 21, 2024
@Ron-Madan Ron-Madan deleted the feature/signup-signin-with-email branch January 11, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE - 2: Firebase Auth: Email/Password
3 participants