-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external/public linter #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little cleaner syntactically as the list of commands grows.
This makes it redundant, but it will be linted against.
Lots of code duplicated from the internal CLI for now.
|
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an external/public linter for rules which theoretically all users of intlc would find useful, and adds a rule there to lint against
{x, select, other {y}}
. Aselect
with only a wildcard branch is redundant and should be replaced withy
.The rule itself covers the first half of #136 (lint against lone wildcard) and #108 (parse/allow lone wildcard), but leaves alone #27 (case ordering). Plurals to come in another PR to prevent this one getting too large. I suggest reviewing commit-by-commit as most of them are small.
Most of the diff is due to a change to
select
in the AST. It's now represented with theThese
type: there can be cases, or a wildcard, or both.At some point we may need to think about merging the rules in some sense so we're not iterating anew for each rule, a bit like how ESLint gives you selectors to match against. We can cross that bridge when we come to it: #143