Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto install @nuxtjs/color-mode module #737

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

selemondev
Copy link
Contributor

@selemondev selemondev commented Aug 29, 2024

Issue: #537

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This pull request is intended to install the @nuxtjs/color-mode module alongside the installation of the shadcn-nuxt module. Why do so? Adding dark mode functionality has become a standard practice for many developers using Shadcn Vue in their web apps. To enhance developer experience (DX), it would be highly beneficial if the @nuxtjs/color-mode module were pre-installed and automatically configured.

Closes: #537

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This pull request is intended to install the  module during the installation of the  module

Closes: unovue#537
@sadeghbarati sadeghbarati merged commit 501137a into unovue:dev Aug 30, 2024
3 checks passed
@Rednas83
Copy link

Rednas83 commented Nov 5, 2024

When this module is used with nuxt 3.14.0 I get
ERROR Cannot start nuxt: Nuxt module should be a function: @nuxtjs/color-mode

------------------------------
- Operating System: Windows_NT
- Node Version:     v22.11.0
- Nuxt Version:     3.14.0
- CLI Version:      3.15.0
- Nitro Version:    2.10.2
- Package Manager:  [email protected]
- Builder:          -
- User Config:      default
- Runtime Modules:  normalizedModule(), normalizedModule(), @vueuse/[email protected], @nuxt/[email protected], @nuxt/[email protected], @nuxtjs/[email protected], @nuxt/[email protected], [email protected], [email protected], @nuxt/[email protected], @formkit/[email protected], @nuxt/[email protected]
- Build Modules:    -
------------------------------

@xak2000
Copy link

xak2000 commented Nov 6, 2024

Related to #864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature(Nuxt): Integrate nuxt/color-mode module
5 participants