more codacy fixes

Unosquare.FFME.Common/ClosedCaptions/ClosedCaptionPacket.cs

@@ -10,7 +10,7 @@
     /// Represents a 3-byte packet of closed-captioning data in EIA-608 format.
     /// See: http://jackyjung.tistory.com/attachment/499e14e28c347DB.pdf
     /// </summary>
-    public sealed class ClosedCaptionPacket : IComparable<ClosedCaptionPacket>
+    public sealed class ClosedCaptionPacket : IComparable<ClosedCaptionPacket>, IEquatable<ClosedCaptionPacket>
     {
         #region Dictionaries
 
@@ -735,6 +735,10 @@ public override bool Equals(object obj)
             return false;
         }
 
+        /// <inheritdoc />
+        public bool Equals(ClosedCaptionPacket other) =>
+            ReferenceEquals(this, other);
+
         /// <inheritdoc />
         public override int GetHashCode()
         {

Unosquare.FFME.Common/Decoding/PacketBufferState.cs

@@ -36,16 +36,10 @@ public bool Equals(PacketBufferState other) =>
 
         /// <inheritdoc />
         public override bool Equals(object obj) =>
-            obj is PacketBufferState && Equals((PacketBufferState)obj);
+            obj is PacketBufferState state && Equals(state);
 
         /// <inheritdoc />
-        public override int GetHashCode()
-        {
-            return
-                Length.GetHashCode() ^
-                Count ^
-                CountThreshold ^
-                HasEnoughPackets.GetHashCode();
-        }
+        public override int GetHashCode() =>
+            throw new NotSupportedException($"{nameof(PacketBufferState)} does not support hashing.");
     }
 }

Unosquare.FFME.Common/Engine/MediaBlock.cs

@@ -11,7 +11,8 @@
     /// Reuse blocks as much as possible. Once you create a block from a frame,
     /// you don't need the frame anymore so make sure you dispose the frame.
     /// </summary>
-    public abstract class MediaBlock : IComparable<MediaBlock>, IComparable<TimeSpan>, IComparable<long>, IDisposable
+    public abstract class MediaBlock
+        : IComparable<MediaBlock>, IComparable<TimeSpan>, IComparable<long>, IEquatable<MediaBlock>, IDisposable
     {
         private readonly object SyncLock = new object();
         private readonly ISyncLocker Locker = SyncLockerFactory.Create(useSlim: true);
@@ -249,9 +250,14 @@ public override bool Equals(object obj)
             return false;
         }
 
+        /// <inheritdoc />
+        public bool Equals(MediaBlock other) =>
+            ReferenceEquals(this, other);
+
         /// <inheritdoc />
         public override int GetHashCode() =>
-            StartTime.Ticks.GetHashCode() ^ m_Buffer.GetHashCode();
+            StartTime.Ticks.GetHashCode() ^
+            MediaType.GetHashCode();
 
         /// <inheritdoc />
         public void Dispose()

Unosquare.FFME.Common/Engine/VideoSeekIndexEntry.cs

@@ -7,7 +7,8 @@
     /// <summary>
     /// Represents a seek entry to a position within the stream
     /// </summary>
-    public sealed class VideoSeekIndexEntry : IComparable<VideoSeekIndexEntry>, IComparable<TimeSpan>
+    public sealed class VideoSeekIndexEntry
+        : IComparable<VideoSeekIndexEntry>, IComparable<TimeSpan>, IEquatable<VideoSeekIndexEntry>
     {
         private static readonly char[] CommaSeparator = new[] { ',' };
 
@@ -152,6 +153,10 @@ public override bool Equals(object obj)
             return false;
         }
 
+        /// <inheritdoc />
+        public bool Equals(VideoSeekIndexEntry other) =>
+            ReferenceEquals(this, other);
+
         /// <inheritdoc />
         public override int GetHashCode() =>
             PresentationTime.GetHashCode() ^

Unosquare.FFME.Windows/Rendering/Wave/DirectSoundPlayer.cs

@@ -654,7 +654,8 @@ public struct DirectSoundBufferPositionNotify : IEquatable<DirectSoundBufferPosi
                 public IntPtr NotifyHandle;
 
                 /// <inheritdoc />
-                public bool Equals(DirectSoundBufferPositionNotify other) => NotifyHandle == other.NotifyHandle;
+                public bool Equals(DirectSoundBufferPositionNotify other) =>
+                    NotifyHandle == other.NotifyHandle;
 
                 /// <inheritdoc />
                 public override bool Equals(object obj)
@@ -666,7 +667,8 @@ public override bool Equals(object obj)
                 }
 
                 /// <inheritdoc />
-                public override int GetHashCode() => NotifyHandle.GetHashCode();
+                public override int GetHashCode() =>
+                    throw new NotSupportedException($"{nameof(DirectSoundBufferPositionNotify)} does not support hashing.");
             }
 
             // ReSharper disable NotAccessedField.Local

Unosquare.FFME.Windows/Rendering/Wave/LegacyAudioDeviceInfo.cs

@@ -147,10 +147,7 @@ public override bool Equals(object obj) =>
 
         /// <inheritdoc />
         public override int GetHashCode() =>
-            manufacturerGuid.GetHashCode() ^
-            productGuid.GetHashCode() ^
-            driverVersion ^
-            channels;
+            throw new NotSupportedException($"{nameof(LegacyAudioDeviceInfo)} does not support hashing.");
 
         /// <summary>
         /// Checks to see if a given SupportedWaveFormat is supported

Unosquare.FFME.Windows/Rendering/Wave/MmTime.cs

@@ -71,10 +71,6 @@ public override bool Equals(object obj) =>
 
         /// <inheritdoc />
         public override int GetHashCode() =>
-            Type.GetHashCode() ^
-            Ms.GetHashCode() ^
-            Sample.GetHashCode() ^
-            CB.GetHashCode() ^
-            Ticks.GetHashCode();
+            throw new NotSupportedException($"{nameof(MmTime)} does not support hashing.");
     }
 }