Build and cross-build Docker images using Nix #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #72 since I'd like to release that change ASAP. |
SQLite database schema has been updated and the Docker build system has been radically changed, I think this warrants a semver minor version bump.
evan-goode
force-pushed
the
docker-cross-build
branch
from
67c21fd
to
60c730f
Compare
|
Bumped version to 1.1.0 due to the magnitude of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70.
This ended up being a bigger change than I anticipated:
dockerTools.buildLayeredImagerather than using a Dockerfile that calls Nix as described here by mitchellh.I think this would have also worked, but I want to experiment with doing it all with Nix.
Also bump version to 1.0.4.