-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardhat-helpers): standalone contracts deploy functions #13233
Conversation
@@ -0,0 +1,20 @@ | |||
export const deployContract = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need a deployUpgradableContract
helper?
Maybe in a follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, added too here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you replace in all the scripts to deploy contracts in the governance
folder?
Do we have tests for |
That will be good indeed. We have tests already in EDIT: I added an example test for the main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all tasks and scripts related to Uniswap V2 deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Want to add that in another PR maybe? |
Yes I added a basic one here but can add more coverage in a separate PR |
Description
This refactoring adds some helpers function for contract deployments so it is easier to deploy on zk chains (see #13078 )
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet