Pulsechain Network Addition #12948

JexxaJ · 2023-11-06T08:52:38Z

Description

Issues

This PR address this issue #9304 (comment)

Checklist:

1 PR, 1 purpose: my Pull Request applies to a single purpose
I have commented my code, particularly in hard-to-understand areas
I have updated the docs to reflect my changes if applicable
I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
I have performed a self-review of my own code
If my code involves visual changes, I am adding applicable screenshots to this thread

cla-bot · 2023-11-06T08:52:41Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

julien51 · 2023-11-06T14:25:22Z

Thanks @JexxaJ Please open another PR with the required changed to the CLA file!
We will review ASAP!

julien51 · 2023-11-06T14:26:21Z

packages/networks/src/networks/index.ts

+export * from './linea'
+export * from './sepolia'
+export * from './pulsechain'
+export * from './pulsechainTestnetV4'


We try to not add all testnets because that means we have to maintain them.
Any reason why Goerli or Sepolia are not enough?

All the development that is done on pulsechain is tried and tested using pulsechain testnet as it replicates the particular way in which the system state was forked over form Eth mainnet. If possible it would be great to see it added as it will foster development using the unlock protocol.

We won't add it as it means more work for our team... if Pulsechain is not compatible with Ethereum test nets then we should not add support for it.

packages/networks/src/networks/pulsechain.ts

julien51 · 2023-11-06T14:27:01Z

packages/networks/src/networks/pulsechain.ts

+
+export const pulsechain: NetworkConfig = {
+    chain: 'pulsechain',
+    description: 'pulsechain mainnet.',


We need a better description here so users know what is specific about Pulsechain please!

Will add something more detailed.

julien51 · 2023-11-06T14:27:36Z

packages/networks/src/networks/pulsechain.ts

+    fullySubsidizedGas: false,
+    id: 369,
+    isTestNetwork: false,
+    keyManagerAddress: '',


packages/networks/src/networks/pulsechain.ts

julien51 · 2023-11-06T14:28:18Z

packages/networks/src/networks/pulsechain.ts

+    isTestNetwork: false,
+    keyManagerAddress: '',
+    maxFreeClaimCost: 10000,
+    multisig: '',


TK

IT looks like Gnosis Safe does not support this chain... can you please confirm?

Correct they have not included pulsechain on the UI, however this network is one of the biggest users of gnosis safes via
https://staker.app/ which is the UI used on pulsechain and ethereum.

The liquid loans team have deployed a cut down version of gnosis on both testnet and mainnet at the below URLs.
https://pulsechainsafe.com/
https://testnet.pulsechainsafe.com/

Let me know if you need more information on these.

At this point we don't want to add more work to our team to maintain non standards setup.

julien51 · 2023-11-06T14:28:36Z

packages/networks/src/networks/pulsechain.ts

+        symbol: 'PLS',
+    },
+    previousDeploys: [],
+    provider: 'https://rpc.unlock-protocol.com/369',


We would need to deploy a provider for this.

julien51 · 2023-11-06T14:28:58Z

packages/networks/src/networks/pulsechain.ts

+    previousDeploys: [],
+    provider: 'https://rpc.unlock-protocol.com/369',
+    publicLockVersionToDeploy: 13,
+    publicProvider: 'https://scan.pulsechain.com',


This is a block explorer. We need an RPC endpoint here.

julien51 · 2023-11-06T14:29:04Z

packages/networks/src/networks/pulsechain.ts

+    provider: 'https://rpc.unlock-protocol.com/369',
+    publicLockVersionToDeploy: 13,
+    publicProvider: 'https://scan.pulsechain.com',
+    startBlock: 2247300,


julien51 · 2023-11-06T14:33:00Z

packages/networks/src/networks/pulsechain.ts

+    publicLockVersionToDeploy: 13,
+    publicProvider: 'https://scan.pulsechain.com',
+    startBlock: 2247300,
+    // Graph can be found at https://graph.pulsechain.com/


Since this is not a standard https://thegraph.com/ setup you need to send us docs on how to set it up.

I will try and get some more info for you on this side of things. Is this a nice to have or required?

Required for the frontend to work

Ok, so there is a community graph node that can be used. I have spoken to the team running this and they have advised while there is no end-user UI at present if you are able to provide the subgraph code you want hosted they will run this up.

Sorry this is too complex for us to maintain so until there is a proper graph deployment we won't merge this PR.

julien51 · 2023-11-06T14:33:07Z

packages/networks/src/networks/pulsechain.ts

+        networkName: 'pulsechain',
+        studioEndpoint: 'unlock-protocol-pulsechain',
+    },
+    unlockAddress: '',


julien51

This is incomplete. Please remove the testnet as well.

Co-authored-by: Julien Genestoux <[email protected]>

cla-bot · 2023-11-06T23:44:59Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

cla-bot · 2023-11-06T23:45:53Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

Co-authored-by: Julien Genestoux <[email protected]>

cla-bot · 2023-11-06T23:50:31Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

cla-bot · 2023-11-07T00:21:37Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

cla-bot · 2023-11-07T00:24:03Z

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JexxaJ on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot.
Thank you!

JexxaJ · 2023-11-13T03:35:26Z

This is incomplete. Please remove the testnet as well.

Can you please have another look over this request and let me know if anything is still outstanding? thanks.

julien51 · 2024-03-29T01:02:50Z

Closing as stale

JexxaJ added 3 commits November 6, 2023 15:06

pulsechain networks added

cb80ca7

pulsechain network added

29b0511

Pulsechain network settings

bb82638

clemsos requested review from julien51 and clemsos November 6, 2023 13:01

julien51 reviewed Nov 6, 2023

View reviewed changes

packages/networks/src/networks/pulsechain.ts Outdated Show resolved Hide resolved

julien51 reviewed Nov 6, 2023

View reviewed changes

packages/networks/src/networks/pulsechain.ts

fullySubsidizedGas: false,

id: 369,

isTestNetwork: false,

keyManagerAddress: '',

Copy link

Member

julien51 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TK

julien51 reviewed Nov 6, 2023

View reviewed changes

packages/networks/src/networks/pulsechain.ts Outdated Show resolved Hide resolved

julien51 reviewed Nov 6, 2023

View reviewed changes

julien51 requested changes Nov 6, 2023

View reviewed changes

Update packages/networks/src/networks/pulsechain.ts

2d1e4eb

Co-authored-by: Julien Genestoux <[email protected]>

Merge branch 'unlock-protocol:master' into pulsechain

b78bdda

Update packages/networks/src/networks/pulsechain.ts

2f140a5

Co-authored-by: Julien Genestoux <[email protected]>

Update pulsechain.ts

efd7e8b

Update pulsechainTestnetV4.ts

5e7de47

Merge branch 'master' into pulsechain

dd3a831

cla-bot bot added the cla-signed label Nov 10, 2023

Merge branch 'master' into pulsechain

c41d95f

julien51 closed this Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pulsechain Network Addition #12948

Pulsechain Network Addition #12948

JexxaJ commented Nov 6, 2023 •

edited

Loading

cla-bot bot commented Nov 6, 2023

julien51 commented Nov 6, 2023

julien51 Nov 6, 2023

JexxaJ Nov 6, 2023 •

edited

Loading

julien51 Nov 21, 2023

julien51 Nov 6, 2023

JexxaJ Nov 7, 2023

julien51 Nov 6, 2023

julien51 Nov 6, 2023

JexxaJ Nov 7, 2023

julien51 Nov 21, 2023

julien51 Nov 6, 2023

julien51 Nov 6, 2023

julien51 Nov 6, 2023

julien51 Nov 6, 2023

JexxaJ Nov 7, 2023

julien51 Nov 7, 2023

JexxaJ Nov 9, 2023

julien51 Nov 21, 2023

julien51 Nov 6, 2023

julien51 left a comment

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 7, 2023

cla-bot bot commented Nov 7, 2023

JexxaJ commented Nov 13, 2023

julien51 commented Mar 29, 2024

Pulsechain Network Addition #12948

Pulsechain Network Addition #12948

Conversation

JexxaJ commented Nov 6, 2023 • edited Loading

Description

Issues

Checklist:

cla-bot bot commented Nov 6, 2023

julien51 commented Nov 6, 2023

Choose a reason for hiding this comment

JexxaJ Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julien51 left a comment

Choose a reason for hiding this comment

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 6, 2023

cla-bot bot commented Nov 7, 2023

cla-bot bot commented Nov 7, 2023

JexxaJ commented Nov 13, 2023

julien51 commented Mar 29, 2024

JexxaJ commented Nov 6, 2023 •

edited

Loading

JexxaJ Nov 6, 2023 •

edited

Loading