Added a stream volume control slider to the Gamebar UI #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamebar UI for use while streaming
… 'click icon to mute'
…y, and a typo from ESLint fix previously
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy, nothing pretty, but it works - styling can easily be adjusted to fit the aesthetic of the app as one sees fit.
Client side volume control is done via adjusting the volume attribute on the audio tag created by xbox-xcloud-player.
Tested on macOS, local streaming to xbox on same wifi. Works great, huge QoL upgrade for me as previously when streaming while also watching youtube/listening to music I would otherwise have to go into every individual game's settings to change the volume, if even possible.
Appreciate the hard work put into this program! Hope I could help!