Refactor ghz_Circuits Error Handling and Update Random Generator in mirror_circuits #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. **Modified GHZ Circuits** (`mitiq/benchmarks/ghz_circuits.py`)
- **Old Code**:
```python
raise ValueError("Cannot prepare a GHZ circuit with {} qubits", n_qubits)
```
- **New Code**:
```python
raise ValueError(f"Cannot prepare a GHZ circuit with {n_qubits} qubits")
```
- **Description**: Updated the error message to use f-string formatting for better clarity and consistency.
2. **Modified Mirror Circuits** (`mitiq/benchmarks/mirror_circuits.py`)
- **Old Code**:
```python
random_state = random.RandomState(seed)
```
- **New Code**:
```python
random_state = random.default_rng(seed)
```
- **Description**: Replaced `RandomState` with `default_rng()` to utilize the modern NumPy random number generator, improving randomness quality and performance.
- Enhanced error messaging in GHZ circuit preparation.
- Updated the random generator method in mirror circuits for better randomness and performance.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ANUKOOL324, thank you for submitting a PR to Mitiq! We will respond as soon as possible, and if you have any questions in the meantime, you can ask us on the Unitary Fund Discord.
|
Hey @cosenal @natestemen ...assist me here ! i am failing test here ! help me ! i am interested in this project ! i doing this under the Hactoberfest 2024 !! please read my PR ! |
- Updated random number generation to use `numpy.random.default_rng()` for improved performance and reproducibility. - Fixed typos in comments and variable names for better readability and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GHZ Circuit Preparation and Mirror Circuit Random Generator
Changes:
Modified GHZ Circuits (
mitiq/benchmarks/ghz_circuits.py)Modified Mirror Circuits (
mitiq/benchmarks/mirror_circuits.py)RandomStatewithdefault_rng()to utilize the modern NumPy random number generator, improving randomness quality and performance.Summary: