Add the theory page of LRE user guide #2522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 89 90 +1
Lines 4131 4156 +25
=======================================
+ Hits 4078 4103 +25
Misses 53 53 ☔ View full report in Codecov by Sentry. |
natestemen
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Going to suggest @vprusso take the first pass at a review of the material. My comments are small and shouldn't overlap (I hope!).
vprusso
reviewed
Oct 2, 2024
purva-thakre
force-pushed
the
lre_theory
branch
from
6f06065
to
2d27879
Compare
natestemen
requested changes
Oct 3, 2024
| The system of linear equations is used to find the numerous $\eta_i$. As we only need to find the noiseless expectation value, we do not need to calculate the full vector of linear combination coefficients if we use the [Lagrange interpolation formula](https://files.eric.ed.gov/fulltext/EJ1231189.pdf). | ||
|
|
||
| $$ | ||
| O_{\rm LRE} = \sum_{i=1}^M \langle O (\boldsymbol{\lambda}_i)\rangle \frac{\det \left(\mathbf{M}_i (\boldsymbol{0}) \right)}{\det \left(\mathbf{A}\right)}. |
There was a problem hiding this comment.
I think we should avoid using
There was a problem hiding this comment.
This is supposed to be one of the terms in the monomial basis evaluated at
Co-authored-by: nate stemen <[email protected]>
purva-thakre
force-pushed
the
lre_theory
branch
from
9d8e974
to
558ef8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2486
License
Before opening the PR, please ensure you have completed the following where appropriate.