-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding layerwise folding as tutorial to mitiq. #1894
Conversation
vprusso
commented
Jun 30, 2023
- Tutorial provided to showcase functionality for layerwise folding and error mitigation.
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 76 76
Lines 3520 3520
=======================================
Hits 3468 3468
Misses 52 52 |
Not sure if I'm missing something, but all of the tests within the |
Thanks @vprusso! This is a great addition to the documentation.
Can you please add the file to the index file, at examples.md? It would be great to include a thumbnail too, including a path for it in the conf.py and adding it to the |
Co-authored-by: Nathan Shammah <[email protected]>
Awesome. Thanks, @nathanshammah. We should be all ✅ now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vincent, very nice example!
Minor suggestions are given below.
Co-authored-by: Andrea Mari <[email protected]>
Thanks again for the comments, @andreamari ! These should all (hopefully) be addressed now. Thank you! |
Thanks for the approval, @andreamari. Any qualms @natestemen , or would you say this is good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Vincent, thanks for putting this together.
Biggest thing is just a minor comment about moving some of the motivational context to the beginning of the tutorial.
So why consider this technique in this context? One reason is that applying | ||
global folding will increase the length of the entire circuit while layerwise | ||
folding on a subset of only the noisiest layers will increase the circuit by a | ||
smaller factor. | ||
|
||
If running a circuit on hardware is bottle-necked by the cost of running a long | ||
circuit, this technique could potentially be used to arrive at a better result | ||
(although not as good as global folding) but with less monetary cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this motivational material should be moved to the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you moved it to the top in 28e0c5f, but wondering if we want remove it from the bottom as well, or it's okay that's it's duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I'm just a fool who left it in there twice. Removed, and thank you for the catch!
Co-authored-by: nate stemen <[email protected]>
Co-authored-by: nate stemen <[email protected]>
Thanks for the comments, @natestemen ! I believe they have been addressed. Let me know if there's anything else, but if not, I think it's good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the approval, @natestemen. I believe things are good (although it seems like the docs are failing for some odd reason). I know that they sometimes do this, so I'm not sure if this is just an artifact of something unrelated. I attempted to rerun the docs build, but it still seems to fail. It mentions something about bsqkit (which I didn't touch in my MR):
Is it okay to merge or should I hold off? |
Yup that's a problem that we are seeing across all PRs are the moment, so no need to worry about that. Sorry for the confusion. I'll let you hit the merge button when you want since it's fun :) |
It is fun! :) Away it goes 🚀 |