Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Hook Deployments #30

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Namespace Hook Deployments #30

merged 3 commits into from
Jun 20, 2024

Conversation

akshatmittal
Copy link
Contributor

@akshatmittal akshatmittal commented Jun 19, 2024 •
edited
Loading

See Uniswap/v4-periphery#122 (comment)

Namespacing the hook deployments avoids writing over reserved addresses.

@saucepoint
Copy link
Collaborator

@akshatmittal thanks, can we namespace it as 0x4444____ i think thats cleaner 😎

@saucepoint
Copy link
Collaborator

and leave a code comment on why we prefix it (i.e. it avoids collision with precompiles)

@akshatmittal
Copy link
Contributor Author

0x4444____

Actually a great idea, how did I miss that!

@saucepoint saucepoint merged commit 0262198 into uniswapfoundation:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshatmittal @saucepoint