Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for version 2.0.0 of the Unikorn image specification for Openstack #86

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

nsricardor
Copy link
Contributor

@nsricardor nsricardor commented Dec 5, 2024

This PR adds support for version 2.0.0 of the OpenStack provider image specification. For detailed information on the updates, refer to the official Unikorn specification for flavors and images:

https://github.com/unikorn-cloud/specifications/blob/main/specifications/providers/openstack/flavors_and_images.md

@nsricardor nsricardor changed the title Handle image properties according to specs v2 Support for version 2.0.0 of the Unikorn image specification for Openstack Dec 5, 2024
@nsricardor nsricardor marked this pull request as ready for review December 5, 2024 09:14
// imageOS extracts the image OS from the image properties.
func (p *Provider) imageOS(image *images.Image) providers.ImageOS {
kernel, _ := image.Properties["unikorn:os:kernel"].(string)
familiy, _ := image.Properties["unikorn:os:familiy"].(string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed -i s/familiy/family/g

Copy link
Member

@spjmurray spjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@spjmurray spjmurray merged commit a7a389e into unikorn-cloud:main Dec 5, 2024
2 checks passed
@nsricardor nsricardor deleted the feature/image-specs-v2 branch December 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants