Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return server status #79

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

nsricardor
Copy link
Contributor

This PR addresses a small fix to the server API endpoints by populating and returning the status field in the server response. Specifically, it ensures that the status field includes both the public and private IP addresses of the provisioned server.

The status field, which is already specified in the server.spec.yaml file, will now contain these IPs, allowing client services like Compute and Slonk to be aware of the server's provisioned network interfaces.

Copy link
Member

@spjmurray spjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be useful for an external observer 😸

@spjmurray spjmurray merged commit b0a2bcf into unikorn-cloud:main Nov 27, 2024
2 checks passed
@nsricardor nsricardor deleted the fix/return-server-status branch November 27, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants