Fix Router Provision Bug (#60)

Error is not getting propagated, and annoyingly the linter didn't pick this up, meaning we say it's okay when a router fails to provision e.g. no more IP addresses, and we get a SIGSEGV.
unikorn-cloud · Sep 30, 2024 · 3fc5d07 · 3fc5d07
1 parent 92161c6
commit 3fc5d07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/charts/region/Chart.yaml b/charts/region/Chart.yaml
@@ -4,8 +4,8 @@ description: A Helm chart for deploying Unikorn's Region Controller
 
 type: application
 
-version: v0.1.40
-appVersion: v0.1.40
+version: v0.1.41
+appVersion: v0.1.41
 
 icon: https://raw.githubusercontent.com/unikorn-cloud/assets/main/images/logos/dark-on-light/icon.png
 

diff --git a/pkg/providers/openstack/provider.go b/pkg/providers/openstack/provider.go
@@ -936,7 +936,7 @@ func (p *Provider) createRouter(ctx context.Context, networkService *NetworkClie
 
 	router, err := networkService.CreateRouter(ctx, "unikorn-openstack-region-provider-router")
 	if err != nil {
-		return nil
+		return err
 	}
 
 	openstackPhysicalNetwork.Spec.RouterID = &router.ID