Enable parallel image pulls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spjmurray Happy to be debate what in this PR should be configurable, and where. |
spjmurray
reviewed
Nov 5, 2024
|
For future reference see here: https://github.com/kubernetes/kubernetes/blob/release-1.31/staging/src/k8s.io/kubelet/config/v1beta1/types.go#L89 |
spjmurray
reviewed
Nov 5, 2024
yankcrime
force-pushed
the
parallel_image_pulls
branch
from
cfbcb8a to
278fcf8
Compare
spjmurray
requested changes
Nov 7, 2024
yankcrime
force-pushed
the
parallel_image_pulls
branch
2 times, most recently
from
98b321e to
1f6d718
Compare
yankcrime
force-pushed
the
parallel_image_pulls
branch
from
1f6d718 to
d537c28
Compare
yankcrime
force-pushed
the
parallel_image_pulls
branch
from
d537c28 to
c28e15b
Compare
As of 1.27, Kubernetes added support for parallelizing image pulls but this is not enabled by default. This is especially useful in situations where multiple images need to be downloaded to a host, but one of them is particularly large.
yankcrime
force-pushed
the
parallel_image_pulls
branch
5 times, most recently
from
1599c82 to
0c88f22
Compare
Passing options such as the one for serializing image pulls has been deprecated (see warning `Flag --serialize-image-pulls has been deprecated`), so do as the warning suggests and pass these in to a file.
yankcrime
force-pushed
the
parallel_image_pulls
branch
from
0c88f22 to
a48495f
Compare
spjmurray
approved these changes
Nov 28, 2024
|
Actually, before I click merge, would you like to to bump the chart version so it gets released? |
|
@spjmurray Done 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 1.27, Kubernetes added support for parallelizing image pulls but this is not enabled by default. This is especially useful in situations where multiple images need to be downloaded to a host, but one of them is particularly large.