Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial functions: part 4 #362

Merged
merged 6 commits into from
Jan 4, 2020
Merged

Financial functions: part 4 #362

merged 6 commits into from
Jan 4, 2020

Conversation

zgordan-vv
Copy link
Contributor

@zgordan-vv zgordan-vv commented Dec 30, 2019

Addresses #356

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #362 into master will decrease coverage by <.01%.
The diff coverage is 56.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   54.69%   54.69%   -0.01%     
==========================================
  Files         199      199              
  Lines       17563    17788     +225     
==========================================
+ Hits         9606     9729     +123     
- Misses       7029     7083      +54     
- Partials      928      976      +48
Impacted Files Coverage Δ
spreadsheet/formula/fnfinance.go 59.01% <56.14%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e59e2...2e4149b. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit fbcea8d into unidoc:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants