Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial functions: part 2 #360

Merged
merged 7 commits into from
Dec 21, 2019
Merged

Financial functions: part 2 #360

merged 7 commits into from
Dec 21, 2019

Conversation

zgordan-vv
Copy link
Contributor

@zgordan-vv zgordan-vv commented Dec 16, 2019

Addresses #356

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #360 into master will increase coverage by 0.18%.
The diff coverage is 57.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #360      +/-   ##
=========================================
+ Coverage   54.52%   54.7%   +0.18%     
=========================================
  Files         199     199              
  Lines       16370   16918     +548     
=========================================
+ Hits         8925    9255     +330     
- Misses       6760    6871     +111     
- Partials      685     792     +107
Impacted Files Coverage Δ
spreadsheet/cell.go 45.82% <100%> (ø) ⬆️
spreadsheet/formula/fnfinance.go 62.17% <57.78%> (-3.13%) ⬇️
spreadsheet/formula/lexer.go 27.22% <0%> (+0.1%) ⬆️
spreadsheet/formula/fndatetime.go 65.39% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64edd6c...102ac7d. Read the comment docs.

@gunnsth gunnsth merged commit dc34147 into unidoc:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants