ICU-22767 Fix GCC warning and turn warning to errors #3129

FrankYFTang · 2024-09-05T03:23:49Z

-Wdangling-pointer can first found in 12.4

Warning Options (Using the GNU Compiler Collection (GCC))

but not in 11.5

-Wstringop-overflow can first found in 11.5

Warning Options (Using the GNU Compiler Collection (GCC))

but not in 10.5

-Wreturn-local-addr first found in 4.8.5

Warning Options - Using the GNU Compiler Collection (GCC)

but not in 4.7.4

-Warray-bounds first found in 4.3.6

Warning Options - Using the GNU Compiler Collection (GCC)

but not in 4.2.4

Checklist

Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22767
Required: The PR title must be prefixed with a JIRA Issue number.
Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
Required: Each commit message must be prefixed with a JIRA Issue number.
Issue accepted (done by Technical Committee after discussion)
Tests included, if applicable
API docs and/or User Guide docs changed or added, if applicable

jira-pull-request-webhook · 2024-09-05T04:31:14Z

Notice: the branch changed across the force-push!

icu4c/source/common/ucurr.cpp is different
icu4c/source/i18n/decNumber.cpp is different
icu4c/source/i18n/formattedvalue.cpp is different
icu4c/source/i18n/number_skeletons.cpp is different
icu4c/source/test/cintltst/utf16tst.c is now changed in the branch
icu4c/source/test/cintltst/utf8tst.c is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2024-09-05T04:47:46Z

Notice: the branch changed across the force-push!

icu4c/source/i18n/formattedvalue.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2024-09-05T06:26:49Z

Notice: the branch changed across the force-push!

icu4c/source/i18n/decNumber.cpp is different
icu4c/source/i18n/formattedvalue.cpp is different
icu4c/source/i18n/number_skeletons.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

roubert · 2024-09-05T12:40:29Z

The gcc-10-stdlib17 tests still fail with -Werror=return-local-addr.

jira-pull-request-webhook · 2024-09-05T17:40:45Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

icu4c/source/common/ucnvmbcs.cpp

icu4c/source/common/ushape.cpp

icu4c/source/test/cintltst/custrtrn.c

FrankYFTang · 2024-09-05T21:14:03Z

@markusicu
I have trouble to reproduce the following in my local machine and understand these messages. Do you have any clue how to fix it?

In file included from ../../../icu4c/source/tools/toolutil/ppucd.cpp:21:
In member function ‘icu_76::UniProps& icu_76::UniProps::operator=(const icu_76::UniProps&)’,
    inlined from ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’ at ../../../icu4c/source/tools/toolutil/ppucd.cpp:239:25:
../../../icu4c/source/tools/toolutil/ppucd.h:43:23: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
   43 | struct U_TOOLUTIL_API UniProps {
      |                       ^~~~~~~~
../../../icu4c/source/tools/toolutil/ppucd.h: In member function ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’:
../../../icu4c/source/tools/toolutil/ppucd.h:49:13: note: at offset 0 to object ‘icu_76::UniProps::start’ with size 4 declared here
   49 |     UChar32 start, end;
      |             ^~~~~
In member function ‘icu_76::UniProps& icu_76::UniProps::operator=(const icu_76::UniProps&)’,
    inlined from ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’ at ../../../icu4c/source/tools/toolutil/ppucd.cpp:235:25:
../../../icu4c/source/tools/toolutil/ppucd.h:43:23: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
   43 | struct U_TOOLUTIL_API UniProps {
      |                       ^~~~~~~~
../../../icu4c/source/tools/toolutil/ppucd.h: In member function ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’:
../../../icu4c/source/tools/toolutil/ppucd.h:49:13: note: at offset 0 to object ‘icu_76::UniProps::start’ with size 4 declared here
   49 |     UChar32 start, end;
      |             ^~~~~
In member function ‘icu_76::UniProps& icu_76::UniProps::operator=(const icu_76::UniProps&)’,
    inlined from ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’ at ../../../icu4c/source/tools/toolutil/ppucd.cpp:248:21:
../../../icu4c/source/tools/toolutil/ppucd.h:43:23: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
   43 | struct U_TOOLUTIL_API UniProps {
      |                       ^~~~~~~~
../../../icu4c/source/tools/toolutil/ppucd.h: In member function ‘const icu_76::UniProps* icu_76::PreparsedUCD::getProps(icu_76::UnicodeSet&, UErrorCode&)’:
../../../icu4c/source/tools/toolutil/ppucd.h:49:13: note: at offset 0 to object ‘icu_76::UniProps::start’ with size 4 declared here
   49 |     UChar32 start, end;
      |             ^~~~~
cc1plus: all warnings being treated as errors
*** Failed compilation command follows: ----------------------------------------------------------

icu4c/source/common/ucnvmbcs.cpp

jira-pull-request-webhook · 2024-09-06T19:27:26Z

Notice: the branch changed across the force-push!

.github/workflows/icu4c.yml is different
icu4c/source/common/ucnvmbcs.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

See unicode-org#3129

jira-pull-request-webhook · 2024-09-09T22:01:13Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2024-09-09T22:23:46Z

Notice: the branch changed across the force-push!

icu4c/source/common/ucnvmbcs.cpp is different
icu4c/source/i18n/decNumber.cpp is different
icu4c/source/i18n/number_rounding.cpp is different
icu4c/source/i18n/number_skeletons.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2024-09-10T21:28:01Z

Notice: the branch changed across the force-push!

icu4c/source/common/ucnvmbcs.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang · 2024-09-11T05:54:40Z

PTAL

.github/workflows/icu4c.yml

roubert

With the warnings added to the gcc-debug-build-and-test job, you got yet one more maybe-uninitialized that'll need to be addressed.

icu4c/source/test/cintltst/uformattedvaluetst.c

icu4c/source/common/ushape.cpp

icu4c/source/i18n/decNumber.cpp

icu4c/source/i18n/formattedvalue.cpp

icu4c/source/i18n/number_rounding.cpp

icu4c/source/test/cintltst/utf16tst.c

icu4c/source/test/cintltst/utf8tst.c

icu4c/source/i18n/decNumber.cpp

jira-pull-request-webhook · 2024-09-25T01:24:52Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

See unicode-org#3129

jira-pull-request-webhook · 2024-09-25T04:36:01Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

See unicode-org#3129

jira-pull-request-webhook · 2024-09-25T04:36:15Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

ICU-22716 use pre-existing task ICU-22716 Fix ICU-22716 Fix unitialization Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <[email protected]> ICU-22716 change macro ICU-22716 Add document about the macro ICU-22716 Addres review feedback ICU-22767 Fix GCC warning and turn warning to errors ICU-22716 use pre-existing task ICU-22716 Fix ICU-22716 Fix unitialization Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <[email protected]> ICU-22716 change macro ICU-22716 Add document about the macro ICU-22716 Addres review feedback ICU-22767 Fix GCC warning and turn warning to errors ICU-22716 use pre-existing task ICU-22716 Fix ICU-22716 Fix unitialization Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <[email protected]> ICU-22767 Fix GCC warning and turn warning to errors ICU-22716 use pre-existing task ICU-22716 Fix ICU-22716 Fix unitialization Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <[email protected]> ICU-22716 change macro ICU-22716 Add document about the macro ICU-22716 Addres review feedback ICU-22767 Fix GCC warning and turn warning to errors ICU-22716 use pre-existing task ICU-22716 Fix ICU-22716 Fix unitialization Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <[email protected]> ICU-22716 change macro ICU-22716 Add document about the macro ICU-22716 Address feedback ICU-22767 Fix GCC warning and turn warning to errors See unicode-org#3129

jira-pull-request-webhook · 2024-09-25T18:22:04Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

See unicode-org#3129

jira-pull-request-webhook · 2024-09-25T22:10:10Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

See unicode-org#3129

jira-pull-request-webhook · 2024-09-25T22:10:41Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang · 2024-09-25T22:38:35Z

PTAL I removed unncessary changes

roubert · 2024-09-26T16:24:19Z

.github/workflows/icu4c.yml

@@ -67,6 +67,8 @@ jobs:

 - name: ICU4C with gcc
 env:
+ CXXFLAGS: -Wextra -Werror -Wno-return-local-addr


Suggested change

CXXFLAGS: -Wextra -Werror -Wno-return-local-addr

CXXFLAGS: -Wextra -Werror -Wno-error=return-local-addr

I recommend not hiding this warning entirely, but instead just not treat it as an error.

FrankYFTang · 2024-09-26T22:28:26Z

During the ICUTC this morning. I agree to Markus we should hold this till 77.1

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 188b66d to 552abea Compare September 5, 2024 04:31

FrankYFTang requested review from roubert and sffc September 5, 2024 04:34

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from b8b4ba9 to 137c405 Compare September 5, 2024 04:47

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 137c405 to d07b151 Compare September 5, 2024 06:26

markusicu requested a review from eggrobin September 5, 2024 16:56

markusicu assigned roubert Sep 5, 2024

FrankYFTang changed the title ~~ICU-22716 Fix GCC warning and turn warning to errors~~ ICU-22767 Fix GCC warning and turn warning to errors Sep 5, 2024

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 3521f13 to aacfcf7 Compare September 5, 2024 17:40

markusicu reviewed Sep 5, 2024

View reviewed changes

icu4c/source/common/ucnvmbcs.cpp Outdated Show resolved Hide resolved

icu4c/source/common/ucnvmbcs.cpp Outdated Show resolved Hide resolved

icu4c/source/common/ushape.cpp Outdated Show resolved Hide resolved

icu4c/source/test/cintltst/custrtrn.c Show resolved Hide resolved

markusicu reviewed Sep 5, 2024

View reviewed changes

icu4c/source/common/ucnvmbcs.cpp Outdated Show resolved Hide resolved

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from a4e208f to 77d4d85 Compare September 6, 2024 19:27

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 9, 2024

ICU-22767 Fix GCC warning and turn warning to errors

d5d0784

See unicode-org#3129

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 8e666e5 to d5d0784 Compare September 9, 2024 22:01

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from d5d0784 to 99d9fb0 Compare September 9, 2024 22:23

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 99d9fb0 to 7d28d61 Compare September 10, 2024 21:27

FrankYFTang requested a review from markusicu September 11, 2024 05:54

roubert reviewed Sep 11, 2024

View reviewed changes

.github/workflows/icu4c.yml Outdated Show resolved Hide resolved

.github/workflows/icu4c.yml Outdated Show resolved Hide resolved

roubert reviewed Sep 11, 2024

View reviewed changes

icu4c/source/test/cintltst/uformattedvaluetst.c Outdated Show resolved Hide resolved

FrankYFTang requested a review from roubert September 12, 2024 07:09

roubert reviewed Sep 12, 2024

View reviewed changes

roubert reviewed Sep 13, 2024

View reviewed changes

icu4c/source/i18n/decNumber.cpp Outdated Show resolved Hide resolved

markusicu added the waiting-on-author label Sep 23, 2024

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from f3255db to 013707e Compare September 25, 2024 01:24

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 25, 2024

ICU-22767 Fix GCC warning and turn warning to errors

7ce8d20

See unicode-org#3129

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 013707e to 7ce8d20 Compare September 25, 2024 04:35

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 25, 2024

ICU-22767 Fix GCC warning and turn warning to errors

1647bd2

See unicode-org#3129

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 7ce8d20 to 1647bd2 Compare September 25, 2024 04:36

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 4f62a55 to 9e89648 Compare September 25, 2024 18:22

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 25, 2024

ICU-22767 Fix GCC warning and turn warning to errors

01c3b54

See unicode-org#3129

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from e6b0be8 to 01c3b54 Compare September 25, 2024 22:10

ICU-22767 Fix GCC warning and turn warning to errors

1627204

See unicode-org#3129

FrankYFTang force-pushed the ICU-22716-fixGCCWarning branch from 01c3b54 to 1627204 Compare September 25, 2024 22:10

FrankYFTang removed the waiting-on-author label Sep 25, 2024

FrankYFTang requested a review from roubert September 25, 2024 22:38

roubert requested changes Sep 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ICU-22767 Fix GCC warning and turn warning to errors #3129

ICU-22767 Fix GCC warning and turn warning to errors #3129

FrankYFTang commented Sep 5, 2024 •

edited

Loading

jira-pull-request-webhook bot commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

roubert commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

FrankYFTang commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 6, 2024

jira-pull-request-webhook bot commented Sep 9, 2024

jira-pull-request-webhook bot commented Sep 9, 2024

jira-pull-request-webhook bot commented Sep 10, 2024

FrankYFTang commented Sep 11, 2024

roubert left a comment

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

FrankYFTang commented Sep 25, 2024

roubert Sep 26, 2024

FrankYFTang commented Sep 26, 2024

	CXXFLAGS: -Wextra -Werror -Wno-return-local-addr
	CXXFLAGS: -Wextra -Werror -Wno-error=return-local-addr

ICU-22767 Fix GCC warning and turn warning to errors #3129

Are you sure you want to change the base?

ICU-22767 Fix GCC warning and turn warning to errors #3129

Conversation

FrankYFTang commented Sep 5, 2024 • edited Loading

Checklist

jira-pull-request-webhook bot commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

roubert commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 5, 2024

FrankYFTang commented Sep 5, 2024

jira-pull-request-webhook bot commented Sep 6, 2024

jira-pull-request-webhook bot commented Sep 9, 2024

jira-pull-request-webhook bot commented Sep 9, 2024

jira-pull-request-webhook bot commented Sep 10, 2024

FrankYFTang commented Sep 11, 2024

roubert left a comment

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

jira-pull-request-webhook bot commented Sep 25, 2024

FrankYFTang commented Sep 25, 2024

roubert Sep 26, 2024

Choose a reason for hiding this comment

FrankYFTang commented Sep 26, 2024

FrankYFTang commented Sep 5, 2024 •

edited

Loading