-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade knex to ^2 #142
Upgrade knex to ^2 #142
Conversation
Thanks for the PR Thyen! I need to fix up some things here before I can deploy a new version. In the meantime, do you know in what version knex changed the paths? I'd like to know what other knex versions could potentially be supported in the peer-dependency range. |
File structured change PR knex/knex#4178 |
Updated the PR with appropriate peer dependency range |
I've update dev deps and gotten tests to run again, would you please rebase your branch Thyen? You can skip commit c30640c that's already applied on master. In the commit that upgrades Knex, you'll also need to update this path in the tests:
I think the new path is |
Donezo! Rebasted with your master changes and updates the .spec.js import reference |
This path also needs an update
And then run |
Applied the lint fixes, updated the node version on |
Perfect, thanks Thyen! |
Released in v5.0.0 |
This PR:
knex
dependency to ^2.5.1