Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to UD-1521 fsgroup behaviour and include runAsGroup #321

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Revert back to UD-1521 fsgroup behaviour and include runAsGroup #321

merged 1 commit into from
Nov 18, 2024

Conversation

knrc
Copy link
Contributor

@knrc knrc commented Nov 6, 2024

Description

Revert back to UD-1512 default behaviour and include runAsGroup in containers.

Linked Issues

How has this been tested?

  • Deployed to local cluster
  • Exec into job pod and check persistent volume permissions
  • Exec into trivy plugin pod and check persistent volume permissions
  • Check job and cronjob yaml to verify fsGroup and runAsGroup entries

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@knrc knrc added the enhancement New feature or request label Nov 6, 2024
@knrc knrc self-assigned this Nov 6, 2024
@knrc knrc requested a review from matheusfm November 6, 2024 00:37
@knrc knrc force-pushed the fsgroup-default branch 2 times, most recently from 6f6990f to ee14679 Compare November 6, 2024 18:11
@knrc knrc merged commit c52ba78 into undistro:main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusfm matheusfm matheusfm approved these changes

Assignees

@knrc knrc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knrc @matheusfm