cleaning up

.github/ISSUE_TEMPLATE/bug_report.md

@@ -8,7 +8,7 @@ assignees: ''
 ---
 
 
-<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/popeye.png" align="right" width="100" height="auto"/>
+<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/popeye_bug.png" align="right" width="100" height="auto"/>
 
 <br/>
 <br/>

.github/ISSUE_TEMPLATE/feature_request.md

@@ -7,7 +7,7 @@ assignees: ''
 
 ---
 
-<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/popeye.png" align="right" width="100" height="auto"/>
+<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/popeye_feature.png" align="right" width="100" height="auto"/>
 
 <br/>
 <br/>

README.md

@@ -1,4 +1,4 @@
-<img src="assets/popeye.png" align="right" width="250" heigh="auto">
+<img src="assets/popeye_logo.png" align="right" width="250" heigh="auto">
 
 # Popeye - A Kubernetes Cluster Sanitizer
 

internal/issues/issues.go

@@ -29,6 +29,7 @@ func (i Issues) MaxSeverity() config.Level {
 	return max
 }
 
+// Sort sorts issues.
 func (i Issues) Sort(l config.Level) Issues {
 	ii := make(Issues, 0, len(i))
 	gg := i.Group()

internal/report/assets/template.html

@@ -180,7 +180,7 @@
     <div class="title">Popeye K8s Sanitizer Report</div>
     <div class="summary">
       <a class="popeye-logo" href="https://github.com/derailed/popeye">
-        <img class="logo" src="https://github.com/derailed/popeye/raw/master/assets/popeye.png" />
+        <img class="logo" src="https://github.com/derailed/popeye/raw/master/assets/popeye_logo.png" />
       </a>
       <div class="score-summary">
         Scanned

internal/report/builder.go

@@ -288,6 +288,7 @@ func (b *Builder) PrintReport(level config.Level, s *Sanitizer) {
 // ----------------------------------------------------------------------------
 // Helpers...
 
+// Titelize renders a section title.
 func Titleize(a *internal.Aliases, res string, count int) string {
 	res = a.FromAlias(res)
 	if count <= 0 || res == "general" {

pkg/config/config_test.go

@@ -25,7 +25,7 @@ func TestNewConfig(t *testing.T) {
 
 func TestNewConfigWithFile(t *testing.T) {
 	var (
-		dir = "assets/sp1.yml"
+		dir = "testdata/sp1.yml"
 		ss  = []string{"s1", "s2"}
 		f   = NewFlags()
 	)
@@ -53,7 +53,7 @@ func TestNewConfigWithFile(t *testing.T) {
 
 func TestNewConfigNoResourceSpec(t *testing.T) {
 	var (
-		dir = "assets/sp2.yml"
+		dir = "testdata/sp2.yml"
 		f   = NewFlags()
 	)
 	f.Spinach = &dir
@@ -69,7 +69,7 @@ func TestNewConfigNoResourceSpec(t *testing.T) {
 
 func TestNewConfigFileToast(t *testing.T) {
 	var (
-		dir = "assets/sp_old.yml"
+		dir = "testdata/sp_old.yml"
 		f   = NewFlags()
 	)
 	f.Spinach = &dir
@@ -80,7 +80,7 @@ func TestNewConfigFileToast(t *testing.T) {
 
 func TestNewConfigFileNoExists(t *testing.T) {
 	var (
-		dir = "assets/spinach.yml"
+		dir = "testdata/spinach.yml"
 		f   = NewFlags()
 	)
 	f.Spinach = &dir

pkg/popeye.go

@@ -290,10 +290,12 @@ type readWriteCloser struct {
 	io.ReadWriter
 }
 
+// Close close read stream.
 func (wC readWriteCloser) Close() error {
 	return nil
 }
 
+// NopWriter fake writer.
 func NopWriter(i io.ReadWriter) io.ReadWriteCloser {
 	return &readWriteCloser{i}
 }