-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JWT-PreProcessor plugin details and wiki page. #608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comments
site/dat/wiki/JWTPreProcessor.wiki
Outdated
@@ -0,0 +1,12 @@ | |||
= JAVA WEB TOKEN(JWT) Pre Processor = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file. The documentation is served from your repo (pointed via helpUrl
)
site/dat/repo/various.json
Outdated
}, | ||
{ | ||
"id": "jwt-preProcessor", | ||
"name": "JWT-PreProcessor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use space in name instead of -
, it will look better for users.
site/dat/repo/various.json
Outdated
"markerClass": "sr.jmeter.jwt.preprocessor.JwtPreProcessor", | ||
"installerClass": "sr.jmeter.jwt.preprocessor.JwtPreProcessor", | ||
"versions": { | ||
"v1.0.0": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't use v
prefix in mapping key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per the review comments. Please review the PR.
Look at the CI failure. Can you compile your plugin using older JDK requirement? This will ensure more people can use it. |
Can I know the Java version which I should compile and test? |
The recommended version is Java 11 |
Hi, Please review the PR with the new build. |
Added a new for plugin-manager
Hi, Updated the Manifest file in the plugin build. Please re-run the build. |
Hi undera, I need some guidance from you to resolve this issue. The class which I gave in markerClass is the implementation of PreProcessor interface and AbstractTestElement class in my plugin. So there is no need to define the main method in that class since it is trigger by the Jmeter application. Could you please guide me what is the class I should give in markerClass and installerClass? Previously in my plugin's manifest included the Main-Class and I changed the build to remove it now. So not sure why the build is failing with main method is not found error. Thank you. |
If your plugin does not have custom installation procedures, you can just omit |
Hi, Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=========================================
Coverage 68.87% 68.87%
Complexity 2598 2598
=========================================
Files 230 230
Lines 15721 15721
Branches 1612 1612
=========================================
Hits 10828 10828
Misses 4093 4093
Partials 800 800 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks good now. |
Hi Andrey,
Thank you for your valuable feedback and support. It is my pleasure to
publish my plugin in jmeter plugin-manager.
Thank you.
…On Tue, Aug 15, 2023 at 7:59 PM Andrey Pokhilko ***@***.***> wrote:
Merged #608 <#608> into
master.
—
Reply to this email directly, view it on GitHub
<#608 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK4QS7KU6BQ3Z7QOGYLOFH3XVNQBTANCNFSM6AAAAAA3P2B77Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Sashika Rangoda*
*BSc. (Hons) in ICT*
*University of Colombo*
|
Hi Team,
I developed a Jmeter PreProcessor plugin for JWT generation and I would like to publish it under the Jmeter-plugin manager. Please review my pull request.
Plugin Repo : https://github.com/sashikaR/jwt-preProcessor