Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1152 #1153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/1152 #1153

wants to merge 2 commits into from

Conversation

micw
Copy link

@micw micw commented Aug 31, 2018

Annotation based configuration of a provider class for custom variables. Solves #1152

Michael Wyraz added 2 commits August 31, 2018 14:09
provider for custom variables
@six42
Copy link
Contributor

six42 commented Sep 23, 2018

Hi Michael,
thanks for contributing.
Your pull request looks similar to #978

Can you update the junit overview page to mention this new feature:
http://localhost:8001/FitNesse.UserGuide.WritingAcceptanceTests.RunningFromJunit
and add a junit test which uses it and serves as documentation and test at the same time.
Ideally write a test which defines at least two variables.

@@ -416,14 +444,21 @@ protected void addExecutionLogListener(RunNotifier notifier, MultipleTestsRunner
testRunner.addExecutionLogListener(new ConsoleExecutionLogListener());
}

protected WikiPage getRootPage() {
if (this.customVariables==null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (this.customVariables==null) {
if (this.customVariables == null) {

* @author mwyraz
*/
public interface CustomVariableProvider {
public Map<String,String> getCustomVariables();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this method also receive the suiteClass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants