uwsgiconfig: Drop Homebrew-specific workaround #2314
Conversation
As of <insert homebrew-core.git commit reference here> the cflags obtained using pkg-config are already correct, so it's no longer necessary to fix them ourselves before use. Reverts: 80c3d65 Signed-off-by: Andrea Bolognani <[email protected]>
|
If we remove the workaround from our side won't it break with people with an older version of yajl installed from brew though? |
Yeah, depending on your platform support policy you might not be able to drop the workaround right away, but after some sensible delay it's going to be okay to assume people have upgraded their system. The exact definition of "sensible" in this context is left to you of course ;) With that in mind, would you be willing to voice your support for this change being made in Homebrew, even though it might be a while before you can actually reap the benefits? If so, please drop a comment in Homebrew/homebrew-core#74516 indicating this and clearly stating your affiliation with the uwsgi project. Thank you! |
|
Hi, just a polite ping :) Any chance you could go to Homebrew/homebrew-core#74516 and show your support for working around the yajl pkg-config issue in Homebrew instead of yajl-using applications? Thanks! |
|
Hi, another polite ping :) It'd be great if you would consider supporting this change in Homebrew! Doing so should only take a few minutes of your time. Thanks :) |
This is a tentative pull request because the necessary changes to Homebrew haven't been accepted yet.
In Homebrew/homebrew-core#74516, the libvirt developers have been attempting to get the yajl issues that 80c3d65 was intended to work around addressed in Homebrew. We have our own, similar workaround already in place, but we believe that the issue would be better fixed once and for all in Homebrew rather than worked around separately in each project that uses yajl and wants to support macOS.
The Homebrew maintainers have, quite understandably, been reluctant to introduce and carry a downstream-only patch. In a recent comment however, the maintainers declared themselves willing to consider incorporating the fix under the condition that at least one more project in addition to libvirt would ask for that to happen.
Would uwsgi developers be willing to join the libvirt developers in asking for this bug in yajl to be addressed in Homebrew instead of being worked around in each project that uses the library?
Thank you for your consideration!