Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add long range tag msg #605

Merged
merged 3 commits into from
Nov 15, 2023
Merged

add long range tag msg #605

merged 3 commits into from
Nov 15, 2023

Conversation

alisonryckman
Copy link
Contributor

Summary

Closes #(Your issue number here)

What features did you add, bugs did you fix, etc?

Did you add documentation to the wiki?

Yes/No (If not explain why not)

How was this code tested?

Summarize how you tested this code. Your objective here is to prove to the reviewers that this code actually works without them having to run it themselves. It is often helpful to include screenshots, tables, graphs, and/or a short write-up of testing procedures. Results can be either from sim, the robot, or both depending on what you think is sufficient for the feature you added.

Did you test this in sim?

Yes/No

Did you test this on the rover?

Yes/No

Did you add unit tests?

Yes/No (If not explain why not)

@alisonryckman
Copy link
Contributor Author

Did we decide on how we wanted to keep track of tag timeouts? I added a timestamp param so we could remove them from the tag list after 30 seconds. Otherwise we can just have all tags be permanent and not time out

@Emerson-Ramey
Copy link
Contributor

Did we decide on how we wanted to keep track of tag timeouts? I added a timestamp param so we could remove them from the tag list after 30 seconds. Otherwise we can just have all tags be permanent and not time out

Yeah I think you are right with percep checking the timestamp and seeing if it is older than a certain timeout constant to evict the tag from the permanent cache.

Also, did we want to have another message called LongRangeTags filled with LongRangeTag tags[]?

@alisonryckman alisonryckman merged commit fd7b41a into master Nov 15, 2023
1 check passed
@alisonryckman alisonryckman deleted the long_range_tag branch November 15, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants