Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delete unuseful config #11927

Merged
merged 4 commits into from
Dec 5, 2023
Merged

docs: delete unuseful config #11927

merged 4 commits into from
Dec 5, 2023

Conversation

hualigushi
Copy link
Contributor

@hualigushi hualigushi commented Dec 3, 2023

删除不生效配置 onError

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 2:46pm

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7408df) 28.81% compared to head (e247c16) 28.81%.
Report is 3 commits behind head on master.

❗ Current head e247c16 differs from pull request most recent head a435a1b. Consider uploading reports for the commit a435a1b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11927   +/-   ##
=======================================
  Coverage   28.81%   28.81%           
=======================================
  Files         489      489           
  Lines       14938    14938           
  Branches     3550     3550           
=======================================
  Hits         4305     4305           
  Misses       9870     9870           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -74,7 +74,6 @@ export const layout: RunTimeLayoutConfig = (initialState) => {
logo: 'https://img.alicdn.com/tfs/TB1YHEpwUT1gK0jSZFhXXaAtVXa-28-27.svg',

// 默认布局调整
rightContentRender: () => <RightContent />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能删这个吧,这是 umi layout 里特有的配置项。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用户反馈说不生效,那我自己再试试看

@hualigushi hualigushi closed this Dec 4, 2023
@hualigushi hualigushi reopened this Dec 4, 2023
@hualigushi hualigushi changed the title docs: delete config not in procomponents docs: delete unuseful config Dec 4, 2023
@fz6m fz6m merged commit c88105b into master Dec 5, 2023
23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/layout-doc branch December 5, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants