-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch container to use SQL 2022 instead of SQL Edge #17262
base: contrib
Are you sure you want to change the base?
Conversation
Hi there @CarlSargunar, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @CarlSargunar, good stuff on starting this PR. Since it's still in draft, just give us a shout if you need anything to get it to a published PR. Otherwise, good luck and we'll check in soon! |
@emmagarland yeah very much WIP - I want to consolidate some of the docs too and update them when I get some time so the Docker stuff all works nice :-) |
Sounds fab!! Looking forward to catching up on the newer stuff |
Just adding this here for my own ref : microsoft/mssql-docker#901 I'll update this later with more info |
This is a draft PR to update the template as per discussion : #17261
Essentially the previously specified container is no longer supported, so needs to be swapped to one which will work on any platform.