Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch container to use SQL 2022 instead of SQL Edge #17262

Draft
wants to merge 4 commits into
base: contrib
Choose a base branch
from

Conversation

CarlSargunar
Copy link
Contributor

This is a draft PR to update the template as per discussion : #17261

Essentially the previously specified container is no longer supported, so needs to be swapped to one which will work on any platform.

Copy link

Hi there @CarlSargunar, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @CarlSargunar, good stuff on starting this PR. Since it's still in draft, just give us a shout if you need anything to get it to a published PR. Otherwise, good luck and we'll check in soon!

@CarlSargunar
Copy link
Contributor Author

@emmagarland yeah very much WIP - I want to consolidate some of the docs too and update them when I get some time so the Docker stuff all works nice :-)

@emmagarland
Copy link
Contributor

Sounds fab!! Looking forward to catching up on the newer stuff

@CarlSargunar
Copy link
Contributor Author

Just adding this here for my own ref : microsoft/mssql-docker#901

I'll update this later with more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants