Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add importer for French cadastre #2223

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: add importer for French cadastre #2223

merged 1 commit into from
Oct 21, 2024

Conversation

yohanboniface
Copy link
Member

Screenshot From 2024-10-18 12-48-23

@yohanboniface
Copy link
Member Author

@Aurelie-Jallut do you want to create a dedicated icon ?

@Aurelie-Jallut
Copy link
Contributor

let's try !
image

image

davidbgk
davidbgk approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good 🙌

umap/static/umap/js/modules/importers/cadastrefr.js Outdated Show resolved Hide resolved
umap/static/umap/js/modules/importers/cadastrefr.js
<option value="communes">Communes</option>
<option value="feuilles">Feuilles</option>
<option value="lieux_dits">Lieux dits</option>
<option value="parcelles" selected>Parcelles</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to put the selected choice at the top of the list, it is a more classic pattern (and I get that it's sorted alphabetically for now but still).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to think that given the list is small, the alphabetical order is more natural and convenient once open. Let's try that way and see ?

@yohanboniface yohanboniface merged commit 037b8e0 into master Oct 21, 2024
4 checks passed
@yohanboniface yohanboniface deleted the cadastrefr-importer branch October 21, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yohanboniface @Aurelie-Jallut @davidbgk