Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

prototype for easier overpass integration #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

datendelphin
Copy link
Contributor

@datendelphin datendelphin commented Nov 1, 2017

screenshot from 2017-11-01 09-30-33

There are open issues:

  • as soon as the settings screen is left, the overpass query disappears
  • the turbo usual {{bbox}} is not yet supported

@datendelphin
Copy link
Contributor Author

Also, right now one could enter both, remote data and overpass, and only one of both would be displayed.

@yohanboniface
Copy link
Member

Okay, I see it a bit better now, thanks :)

IMHO, having a new dedicated form parallel to "remote data' is not the best move: as you mention yourself, this will conflict, and it will not work for a one short import (through the import panel).

What I suggest instead is to have a form on top the URL field that helps generating the final URL, both from remote data and import panel.

So, roughly, something like an "overpass wizard" button that open a new modal box, with at least the following fields:

  • feature (text input)
  • limit to current bbox? (check box)

With those infos, we would generate the final overpass URL we'd then put in the URL field the wizard was attached to.

@yohanboniface
Copy link
Member

Oh, nice, the Overpass Turbo wizard is now a separate module, yay!

https://github.com/tyrasd/overpass-wizard

So in my above description, the new modal would expose the wizard.

@yohanboniface
Copy link
Member

Ref tyrasd/overpass-turbo#95

@datendelphin
Copy link
Contributor Author

Thank you for the input. Do you have anything in mind which is already in umap and similar? Something like the advanced action buttons? Or more like the User interface options toggles?

Also for the modal box, are there any examples I could use as a starting point? Something like the confirmation dialogue when one deletes the map? Or more like the question mark info boxes?

@yohanboniface
Copy link
Member

I think you can start simple: just add a new form below the remote data URL input with the needed fields and a "generate" button that will call the wizard and populate the URL input.
Later we'll make this form more generic (so it can be attached to any URL input), and togglable or in a modal (so it's displayed only on request).

@datendelphin
Copy link
Contributor Author

Sorry for the long delay. Here is the wizard like approach.

overpass-wizard-like

It takes the overpass query, optionally replaces {{bbox}} with the umap flavoured parameters, and sets the url, the format and the dynamic option of the remote data. So far so good?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants