Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings #79

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add docstrings #79

merged 1 commit into from
Feb 22, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Feb 22, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancements to annotation conversion scripts for YOLO format.

πŸ“Š Key Changes

  • Added docstrings for functions to improve code documentation.
  • Introduced an option to delete .DS_Store files from Apple systems.
  • Functions now have explicit functionality comments, making it easier for developers to understand their purpose.
  • Additional options in COCO JSON conversion such as segment support and class mapping.

🎯 Purpose & Impact

  • πŸ“ Improved Documentation: Clearer code comments and docstrings help developers and users understand the conversion process between different annotation formats and YOLO.
  • πŸ“ Dataset Cleanup: .DS_Store deletion keeps the dataset directories clean, especially for non-Apple users who might encounter issues with these files.
  • 🌐 User Flexibility: The ability to handle segments and class mappings in COCO JSON conversion caters to a wider range of use cases and datasets.
  • πŸ› οΈ Better Code Maintenance: With clearer function descriptions, maintaining and updating the codebase will be simpler for contributors.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: This pull request focuses on enhancing the codebase by adding comprehensive docstrings to various functions across multiple files. These additions aim to improve the readability and maintainability of the code by clearly describing the purpose, functionality, and usage of the functions involved. The changes span across functions responsible for converting JSON annotations to YOLO format, handling file directories, and manipulating image data.

Decision: Comment

πŸ“ Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
βœ… Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
βœ… Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that all newly added docstrings follow a consistent format and style for better readability.
  • Consider adding more detailed descriptions in the docstrings where necessary to provide deeper insights into the function's logic or its parameters.
  • Review the docstrings for any potential grammatical or typographical errors to maintain professionalism in the code documentation.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment to tell me if it was helpful.

general_json2yolo.py Show resolved Hide resolved
general_json2yolo.py Show resolved Hide resolved
@glenn-jocher glenn-jocher merged commit 5013314 into master Feb 22, 2024
1 check passed
@glenn-jocher glenn-jocher deleted the docstrings branch February 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant