Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getpolygons function for Image segmentation with labelbox json (Sourcery refactored) #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Mar 29, 2023

Pull Request #40 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/ultralytics/JSON2YOLO pull/40/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

📊 Key Changes

  • Added a new function getPolygons to process image segmentation data from Labelbox JSON format.
  • The function converts images to grayscale, finds contours, and approximates polygons from these contours.
  • Drawn contours on images have been refactored for clarity and to ensure data is formatted correctly.

🎯 Purpose & Impact

  • This update brings image segmentation capabilities to the JSON to YOLO conversion tool, enabling users to convert complex shapes to a format compatible with YOLO object detection models.
  • 🖼 It could greatly streamline the workflow for projects involving image segmentation, making it easier for data scientists and developers to prepare their data for machine learning applications.

🌟 Summary

"New getPolygons function enhances Labelbox JSON to YOLO conversion tool with powerful image segmentation support for ML model training." 🌐🖌✨

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Mar 29, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 42.27%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 21.00 ⭐ 80.33 🙂 59.33 👎
Working memory 1.00 ⭐ 11.86 😞 10.86 👎
Quality 99.00% 56.73% 🙂 -42.27% 👎
Other metrics Before After Change
Lines 12 41 29
Changed files Quality Before Quality After Quality Change
labelbox_json2yolo.py 99.00% ⭐ 56.73% 🙂 -42.27% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
labelbox_json2yolo.py getPolygons 1 ⭐ 199 😞 13 😞 52.28% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant