Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented argparse for general_JSON2YOLO and update readem with an "How to use" section #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GiorgioSgl
Copy link

@GiorgioSgl GiorgioSgl commented Mar 25, 2021

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

📊 Key Changes

  • Implemented argparse in general_json2yolo.py to handle command-line arguments.
  • Updated the README.md with a new "How to use" section.
  • Added argparse to the requirements.txt file.

🎯 Purpose & Impact

  • The introduction of argparse allows users to specify parameters like json_dir and source directly from the command line. This increases flexibility and usability for different datasets.
  • The update to the README.md provides clear instructions on how to use the tool, improving accessibility for new users.
  • Including argparse in requirements ensures users will have the necessary packages installed.

🌟 Summary

🛠️ The PR enhances the JSON2YOLO tool by adding command-line functionality and user guidance in the documentation.

@hlydecker
Copy link

Was gonna submit a pr to do the same thing; CLI arguments make this so much more usable. Would be great for using this in pipelines involving COCO annotation files!

source = 'coco'

parser = argparse.ArgumentParser()
parser.add_argument('-json_dir', action='store', help='please include the full path of the folder with bounding boxes (.json)', type=str)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use relative paths?

@glenn-jocher
Copy link
Member

That's great to hear! Adding CLI arguments does indeed improve usability, especially for integration into annotation pipelines. Your contribution would be much appreciated. Thank you for feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants